Suffix Chrome's appid on user-level installs

chrome/browser/shell_integration.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_
 #define CHROME_BROWSER_SHELL_INTEGRATION_H_
 #pragma once
 
 #include <string>
 
@@ skipping 105 matching lines @@
   // login profile, for ChromeOS).
   // If |extension_app_id| is non-empty, the arguments use kAppId=<id>.
   // Otherwise, kApp=<url> is used. If |is_platform_app| is true the flag
   // --enable-platform-apps is added to the command line.
   static CommandLine CommandLineArgsForLauncher(
       const GURL& url,
       const std::string& extension_app_id,
       bool is_platform_app);
 
 #if defined(OS_WIN)
   // Generates Win7 app id for given app name and profile path. The returned app

[grt (UTC plus 2), 2012/06/15 03:03:03]

"Generates an application user model ID (AppUserModelID) for a given..."

[gab, 2012/06/15 19:01:04]

Done.

   // id is in the format of "|app_name|[.<profile_id>]". "profile_id" is
   // appended when user override the default value.
-  static string16 GetAppId(const string16& app_name,
-                           const FilePath& profile_path);
+  // Note: If the app has an installation specific suffix (e.g. on user-level
+  // Chrome installs), |app_name| should already be suffixed, this method will
+  // then further suffix it with the profile id as described above.
+  static string16 GetProfileAppId(const string16& app_name,

[grt (UTC plus 2), 2012/06/15 03:03:03]

"Profile" in the name of this function is misleading.  the point of this
function is to return a user model id that is specific to some app (not
necessarily chrome/chromium) and a profile.  i suggest changing this method to
GetAppModelId and the one below to GetChromiumModelId.  or something like that.

[gab, 2012/06/15 19:01:04]

I like :).

+                                  const FilePath& profile_path);
 
-  // Generates Win7 app id for Chromium by calling GetAppId with
-  // chrome::kBrowserAppID as app_name.
+  // Generates Win7 app id for Chromium by calling GetProfileAppId with

[grt (UTC plus 2), 2012/06/15 03:03:03]

"Generates an application user model ID (AppUserModelID) for Chromium..."

[gab, 2012/06/15 19:01:04]

Done.

+  // ShellUtil::GetAppId as app_name.
   static string16 GetChromiumAppId(const FilePath& profile_path);
 
   // Returns the path to the Chromium icon. This is used to specify the icon
   // to use for the taskbar group on Win 7.
   static string16 GetChromiumIconPath();
 
   // Migrates existing chrome shortcuts by tagging them with correct app id.
   // see http://crbug.com/28104
   static void MigrateChromiumShortcuts();
 
@@ skipping 135 matching lines @@
     // Set Chrome as the default handler for this protocol.
     virtual void SetAsDefault(bool interactive_permitted) OVERRIDE;
 
     std::string protocol_;
 
     DISALLOW_COPY_AND_ASSIGN(DefaultProtocolClientWorker);
   };
 };
 
 #endif  // CHROME_BROWSER_SHELL_INTEGRATION_H_