Issue 10542002: Replace SharedFunctionInfo::EnsureCompiled with JSFunction::CompileLazy where possible.

Issue 10542002: Replace SharedFunctionInfo::EnsureCompiled with JSFunction::CompileLazy where possible. (Closed)

Created:
8 years, 6 months ago by ulan

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Replace SharedFunctionInfo::EnsureCompiled with JSFunction::CompileLazy where possible. After we get rid of all SharedFunctionInfo::EnsureCompiled calls, it will be possible to remove the HasTrivialOuterContext() condition in Scope::AllowsLazyCompilation. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11715

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	src/bootstrapper.cc	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
	M	src/runtime.cc	View	1	3 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a few nits). https://chromiumcodereview.appspot.com/10542002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://chromiumcodereview.appspot.com/10542002/diff/1/src/bootstrapper.cc#newcode2095 src/bootstrapper.cc:2095: Handle<SharedFunctionInfo> shared Move that ...

8 years, 6 months ago (2012-06-05 12:07:41 UTC) #2

ulan

8 years, 6 months ago (2012-06-05 13:14:16 UTC) #3

https://chromiumcodereview.appspot.com/10542002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://chromiumcodereview.appspot.com/10542002/diff/1/src/bootstrapper.cc#ne...
src/bootstrapper.cc:2095: Handle<SharedFunctionInfo> shared
On 2012/06/05 12:07:41, Michael Starzinger wrote:
> Move that below the compilation, or inline it into set_javascript_builtin_code
> completely.

Done.

https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc#newcode...
src/runtime.cc:12506: Handle<SharedFunctionInfo> shared(func->shared());
On 2012/06/05 12:07:41, Michael Starzinger wrote:
> The shared function is no longer needed, just drop it.

Done.

https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc#newcode...
src/runtime.cc:12522: Handle<SharedFunctionInfo> shared(func->shared());
On 2012/06/05 12:07:41, Michael Starzinger wrote:
> Likewise.

Done.

https://chromiumcodereview.appspot.com/10542002/diff/1/src/runtime.cc#newcode...
src/runtime.cc:12526: shared->construct_stub()->PrintLn();
On 2012/06/05 12:07:41, Michael Starzinger wrote:
> Just inline the func->shared() here.

Done.

Expand Messages | Collapse Messages