Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10541180: Cleanup build system (Closed)

Created:
8 years, 6 months ago by noelallen1
Modified:
8 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Cleanup build system Remove old Makefiles Move hello_world_newlib -> hello_world Remove hello_world_glibc Remove hello_world_pnacl TBR=binji@chromium.org BUG=130618 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142322

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -2139 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/examples/debugging/Makefile View 2 1 chunk +0 lines, -120 lines 0 comments Download
D native_client_sdk/src/examples/dlopen/Makefile View 2 1 chunk +0 lines, -134 lines 0 comments Download
D native_client_sdk/src/examples/file_histogram/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/file_io/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/fullscreen_tumbler/Makefile View 2 1 chunk +0 lines, -78 lines 0 comments Download
D native_client_sdk/src/examples/gamepad/Makefile View 2 1 chunk +0 lines, -90 lines 0 comments Download
D native_client_sdk/src/examples/geturl/Makefile View 2 1 chunk +0 lines, -73 lines 0 comments Download
A native_client_sdk/src/examples/hello_world/example.dsc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world/hello_world.c View 1 2 1 chunk +183 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world/hello_world.html View 1 2 1 chunk +109 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/hello_world/hello_world.nmf View 1 2 1 chunk +6 lines, -0 lines 1 comment Download
D native_client_sdk/src/examples/hello_world_interactive/Makefile View 2 1 chunk +0 lines, -70 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_newlib/Makefile View 2 1 chunk +0 lines, -61 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_newlib/example.dsc View 2 1 chunk +0 lines, -21 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_newlib/hello_world.c View 2 1 chunk +0 lines, -183 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_newlib/hello_world.html View 2 1 chunk +0 lines, -109 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_newlib/hello_world.nmf View 2 1 chunk +0 lines, -6 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_pnacl/Makefile View 2 1 chunk +0 lines, -67 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_pnacl/hello_world.c View 2 1 chunk +0 lines, -182 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_pnacl/hello_world.html View 2 1 chunk +0 lines, -87 lines 0 comments Download
D native_client_sdk/src/examples/hello_world_pnacl/hello_world.nmf View 2 1 chunk +0 lines, -7 lines 0 comments Download
D native_client_sdk/src/examples/input_events/Makefile View 2 1 chunk +0 lines, -89 lines 0 comments Download
D native_client_sdk/src/examples/load_progress/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/mouselock/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/multithreaded_input_events/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/pi_generator/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/pong/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/sine_synth/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/examples/tumbler/Makefile View 2 1 chunk +0 lines, -77 lines 0 comments Download
D native_client_sdk/src/examples/websocket/Makefile View 2 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10541180/4002
8 years, 6 months ago (2012-06-14 21:16:03 UTC) #1
commit-bot: I haz the power
Try job failure for 10541180-4002 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-14 23:45:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10541180/4002
8 years, 6 months ago (2012-06-15 00:10:34 UTC) #3
commit-bot: I haz the power
Change committed as 142322
8 years, 6 months ago (2012-06-15 02:16:01 UTC) #4
binji
8 years, 6 months ago (2012-06-18 18:38:35 UTC) #5 
lgtm

https://chromiumcodereview.appspot.com/10541180/diff/4002/native_client_sdk/s...
File native_client_sdk/src/examples/hello_world/hello_world.nmf (right):

https://chromiumcodereview.appspot.com/10541180/diff/4002/native_client_sdk/s...
native_client_sdk/src/examples/hello_world/hello_world.nmf:1: {
auto-generated, right?

Powered by Google App Engine
This is Rietveld 408576698