Issue 10541176: Remove duplicate includes for unit_test targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10541176: Remove duplicate includes for unit_test targets. (Closed)

Created:
8 years, 6 months ago by nilesh

Modified:
8 years, 6 months ago

Reviewers:
John Grabowski, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove duplicate includes for unit_test targets. This fixes some of the multiple definition errors while building unit_tests as a shared library. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142299

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -11 lines)			Patch
	M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/chrome_tests.gypi	View	1 2	5 chunks	+0 lines, -11 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10541176/1003

8 years, 6 months ago (2012-06-14 20:04:09 UTC) #3

commit-bot: I haz the power

Try job failure for 10541176-1003 (retry) on win_rel for step "browser_tests". It's a second try, ...

8 years, 6 months ago (2012-06-14 22:37:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10541176/1003

8 years, 6 months ago (2012-06-14 23:30:30 UTC) #6

Change committed as 142299