Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

Issue 10541140: re-writes some static field negative tests for use with analyzer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: # Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | tests/language/static_field_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
index 877f76ba2d48f05f8bc65c3ba06383ae617a1e9e..6be06a85ca3745fcee741adfa259255661bbd42a 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
@@ -91,7 +91,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
errEx(TypeErrorCode.TYPE_ALIAS_CANNOT_REFERENCE_ITSELF, 3, 1, 15),
errEx(TypeErrorCode.TYPE_ALIAS_CANNOT_REFERENCE_ITSELF, 4, 1, 17));
}
-
+
/**
* It is a compile-time error if a typedef refers to itself via a chain of references that does
* not include a class or interface type.
@@ -117,7 +117,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
errEx(TypeErrorCode.TYPE_ALIAS_CANNOT_REFERENCE_ITSELF, 6, 1, 16),
errEx(TypeErrorCode.TYPE_ALIAS_CANNOT_REFERENCE_ITSELF, 7, 1, 19));
}
-
+
/**
* It is a compile-time error if initializer list contains an initializer for a variable that
* is not an instance variable declared in the immediately surrounding class.
@@ -136,7 +136,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
libraryResult.getErrors(),
errEx(ResolverErrorCode.INIT_FIELD_ONLY_IMMEDIATELY_SURROUNDING_CLASS, 4, 9, 1));
}
-
+
/**
* Tests that we correctly provide {@link Element#getEnclosingElement()} for method of class.
*/
@@ -257,7 +257,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
libraryResult.getErrors(),
errEx(TypeErrorCode.CASE_EXPRESSION_SHOULD_BE_INT_STRING, 11, 10, 3));
}
-
+
/**
* It is a compile-time error if the values of the case expressions do not all have the same type.
* <p>
@@ -1017,7 +1017,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertErrors(libraryResult.getErrors());
}
-
+
public void test_assert_asLocalVariable() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"// filler filler filler filler filler filler filler filler filler filler",
@@ -1055,7 +1055,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
errEx(TypeErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE, 12, 9, 3),
errEx(TypeErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE, 13, 9, 3));
}
-
+
/**
* If "this.field" parameter has declared type, it should be assignable to the field.
* <p>
@@ -1481,9 +1481,9 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
" A get field() { return getterField; }",
" void set field(arg) { setterField = arg; }",
"}");
- assertErrors(result.getErrors());
+ assertErrors(result.getErrors());
}
-
+
public void test_setterGetterAssignable2() throws Exception {
AnalyzeLibraryResult result =
analyzeLibrary(
@@ -1499,9 +1499,9 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
" get field() { return getterField; }",
" void set field(A arg) { setterField = arg; }",
"}");
- assertErrors(result.getErrors());
- }
-
+ assertErrors(result.getErrors());
+ }
+
public void test_setterGetterNotAssignable() throws Exception {
AnalyzeLibraryResult result =
analyzeLibrary(
@@ -1518,7 +1518,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
" A get field() { return getterField; }",
" void set field(B arg) { setterField = arg; }",
"}");
- assertErrors(result.getErrors(),
+ assertErrors(result.getErrors(),
errEx(TypeErrorCode.SETTER_TYPE_MUST_BE_ASSIGNABLE, 7, 19, 5),
errEx(TypeErrorCode.SETTER_TYPE_MUST_BE_ASSIGNABLE, 12, 18, 5));
}
@@ -1615,7 +1615,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
assertInferredElementTypeString(libraryResult, "v" + i, expectedTypeString);
}
}
-
+
public void test_typesPropagation_secondAssign_sameType() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f() {",
@@ -1625,7 +1625,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertInferredElementTypeString(libraryResult, "v", "bool");
}
-
+
public void test_typesPropagation_secondAssign_differentType() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f() {",
@@ -1635,7 +1635,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertInferredElementTypeString(libraryResult, "v", "<dynamic>");
}
-
+
/**
* When we can not identify type of assigned value we should keep "Dynamic" as type of variable.
*/
@@ -1691,7 +1691,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
assertInferredElementTypeString(libraryResult, "a2", "int");
assertInferredElementTypeString(libraryResult, "b1", "int");
}
-
+
/**
* When single variable has conflicting type constraints, right now we don't try to unify them,
* instead we fall back to "Dynamic".
@@ -1738,7 +1738,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
assertInferredElementTypeString(libraryResult, "a1", "String");
assertInferredElementTypeString(libraryResult, "b1", "List<String>");
}
-
+
public void test_typesPropagation_ifIsType_or() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f(var v) {",
@@ -1753,7 +1753,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
assertInferredElementTypeString(libraryResult, "v1", "<dynamic>");
assertInferredElementTypeString(libraryResult, "v2", "<dynamic>");
}
-
+
public void test_typesPropagation_whileIsType() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f(var v) {",
@@ -1850,7 +1850,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertInferredElementTypeString(libraryResult, "v1", "<dynamic>");
}
-
+
public void test_typesPropagation_ifIsNotType_otherThen() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f(var v) {",
@@ -1862,7 +1862,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertInferredElementTypeString(libraryResult, "v1", "<dynamic>");
}
-
+
public void test_typesPropagation_ifIsNotType_hasThenThrow_withCatch() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f(var v) {",
@@ -1877,7 +1877,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertInferredElementTypeString(libraryResult, "v1", "<dynamic>");
}
-
+
public void test_typesPropagation_ifIsNotType_or() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f(var p1, var p2) {",
@@ -1915,7 +1915,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertInferredElementTypeString(libraryResult, "v1", "<dynamic>");
}
-
+
public void test_typesPropagation_ifIsNotType_not2() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"f(var v) {",
@@ -2191,7 +2191,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertErrors(libraryResult.getErrors());
}
-
+
/**
* It is a static warning if the return type of the user-declared operator negate is explicitly
* declared and not a numerical type.
@@ -2222,7 +2222,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
errEx(TypeErrorCode.OPERATOR_NEGATE_NUM_RETURN_TYPE, 12, 3, 6),
errEx(TypeErrorCode.OPERATOR_NEGATE_NUM_RETURN_TYPE, 15, 3, 6));
}
-
+
/**
* It is a static warning if the return type of the user-declared operator equals is explicitly
* declared and not bool.
@@ -2279,7 +2279,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"}",
"interface J extends I {",
" get foo();",
- " set bar();",
+ " set bar();",
"}");
assertErrors(libraryResult.getTypeErrors(),
errEx(TypeErrorCode.SUPERTYPE_HAS_METHOD, 8, 7, 3),
@@ -2341,7 +2341,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
// ,errEx(ResolverErrorCode.BUILT_IN_IDENTIFIER_AS_TYPE, 15, 3, 7)
);
}
-
+
public void test_supertypeHasField() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"// filler filler filler filler filler filler filler filler filler filler",
@@ -2352,12 +2352,12 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"}",
"interface J extends I {",
" foo();",
- " bar();",
+ " bar();",
"}");
assertErrors(libraryResult.getTypeErrors(),
errEx(TypeErrorCode.SUPERTYPE_HAS_FIELD, 8, 3, 3),
errEx(TypeErrorCode.SUPERTYPE_HAS_FIELD, 9, 3, 3));
- }
+ }
public void test_supertypeHasGetterSetter() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
@@ -2369,13 +2369,13 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"}",
"interface J extends I {",
" foo();",
- " bar();",
+ " bar();",
"}");
assertErrors(libraryResult.getTypeErrors(),
errEx(TypeErrorCode.SUPERTYPE_HAS_FIELD, 8, 3, 3),
errEx(TypeErrorCode.SUPERTYPE_HAS_FIELD, 9, 3, 3));
}
-
+
/**
* <p>
* http://code.google.com/p/dart/issues/detail?id=3280
@@ -2392,7 +2392,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertErrors(libraryResult.getErrors());
}
-
+
/**
* <p>
* http://code.google.com/p/dart/issues/detail?id=3344
@@ -2411,7 +2411,30 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertErrors(libraryResult.getErrors());
}
-
+
+ public void test_staticMemberAccessThroughInstance() throws Exception {
+ AnalyzeLibraryResult libraryResult = analyzeLibrary(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "class A {",
+ " static var x;",
+ " static y() {}",
+ " static method() {",
+ " var a = new A();",
+ " a.x = 1;",
+ " var foo = a.x;",
+ " a.y();",
+ " a.y = 1;",
+ " }",
+ "}",
+ "");
+ assertErrors(libraryResult.getErrors(),
+ errEx(TypeErrorCode.STATIC_MEMBER_ACCESSED_THROUGH_INSTANCE, 7, 7, 1),
+ errEx(TypeErrorCode.STATIC_MEMBER_ACCESSED_THROUGH_INSTANCE, 8, 17, 1),
+ errEx(TypeErrorCode.IS_STATIC_METHOD_IN, 9, 7, 1),
+ errEx(TypeErrorCode.STATIC_MEMBER_ACCESSED_THROUGH_INSTANCE, 10, 7, 1));
+
+ }
+
private AnalyzeLibraryResult analyzeLibrary(String... lines) throws Exception {
return analyzeLibrary(getName(), makeCode(lines));
}
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | tests/language/static_field_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698