re-writes some static field negative tests for use with analyzer

tests/language/static_field_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Dart test program for testing setting/getting/initializing static fields.
 
 class First {
   First() {}
   static var a;
   static var b;
   static final int c = 1;
@@ skipping 44 matching lines @@
     First.b = First.a = 15;
     Expect.equals(15, First.a);
     Expect.equals(15, First.b);
     Expect.equals(35, First.setValues());
     Expect.equals(24, First.a);
     Expect.equals(10, First.b);
   }
 }
 
 
+class StaticField1RunNegativeTest {
+  static  /// 01: static type warning, runtime error
+    var x;
+  static testMain() {
+    var foo = new StaticField1RunNegativeTest();

[ahe, 2012/06/13 14:27:24]

Here I would say:

print(x);

to make sure x is "compiled".

[zundel, 2012/06/13 15:15:43]

Done.

+    var x = foo.x;

[ahe, 2012/06/13 14:27:24]

I would put the /// comment on this line.

Also, I would not shadow "x"

[zundel, 2012/06/13 15:15:43]

Got rid of the shadowing, but left the other in place so that in the base case
we see that the code actually would have worked.

+  }
+}
+
+class StaticField1aRunNegativeTest {
+  static  /// 02: static type warning, runtime error
+    void m() {}
+
+  static testMain() {
+    var foo = new StaticField1aRunNegativeTest();
+    var m = foo.m;

[ahe, 2012/06/13 14:27:24]

Ditto. For all three remarks above.

+  }
+}
+
+class StaticField2RunNegativeTest {
+  static /// 03:  static type warning, runtime error
+    var x;
+
+  static testMain() {
+    var foo = new StaticField2RunNegativeTest();
+    foo.x = 1;

[ahe, 2012/06/13 14:27:24]

Ditto (all three).

+  }
+}
+
+class StaticField2aRunNegativeTest {
+  static void m() {} /// 04: static type warning, runtime error
+
+  static testMain() {
+    var foo = new StaticField2aRunNegativeTest();
+    foo.m = 1; /// 04:continued

[ahe, 2012/06/13 14:27:24]

Ditto (all three).

[zundel, 2012/06/13 15:15:43]

I'm not sure the original author of this test realized that no matter if the
method m() is static or an instance method, this line would fail.  In any case,
I did comment out the assignment for this test to get the base case to run.

+  }
+}
+
 main() {
   StaticFieldTest.testMain();
   InitializerTest.testStaticFieldInitialization();
+  StaticField1RunNegativeTest.testMain();
+  StaticField1aRunNegativeTest.testMain();
+  StaticField2RunNegativeTest.testMain();
+  StaticField2aRunNegativeTest.testMain();
 }