Issue 10541139: Improve MakeWebKeyboardEventFromAuraEvent()

Issue 10541139: Improve MakeWebKeyboardEventFromAuraEvent() (Closed)

Created:
8 years, 6 months ago by Yusuke Sato

Modified:
8 years, 6 months ago

Reviewers:
jam, Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch-content_chromium.org, Avi (use Gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Improve MakeWebKeyboardEventFromAuraEvent() so a web page could receive a DOM3 spec compliant keyboard event. BUG=127142 TEST=ran content_unittests + manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142209

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -29 lines)			Patch
M	content/browser/renderer_host/web_input_event_aura.h	View	1	2 chunks	+13 lines, -6 lines	0 comments	Download
A	content/browser/renderer_host/web_input_event_aura_unittest.cc	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aurax11.cc	View		3 chunks	+28 lines, -23 lines	0 comments	Download
M	content/content_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 11 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10541139/6003

8 years, 6 months ago (2012-06-14 15:57:14 UTC) #3

commit-bot: I haz the power

Presubmit check for 10541139-6003 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 6 months ago (2012-06-14 15:57:19 UTC) #4

jam

On 2012/06/14 15:59:37, Yusuke Sato wrote: > +jam > John, could you do an owners ...

8 years, 6 months ago (2012-06-14 16:12:30 UTC) #6

Yusuke Sato

Thanks! On 2012/06/14 16:12:30, John Abd-El-Malek wrote: > On 2012/06/14 15:59:37, Yusuke Sato wrote: > ...

8 years, 6 months ago (2012-06-14 16:18:16 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10541139/6003

8 years, 6 months ago (2012-06-14 16:18:27 UTC) #8

commit-bot: I haz the power

Try job failure for 10541139-6003 (retry) on linux_rel for step "net_unittests". It's a second try, ...

8 years, 6 months ago (2012-06-14 17:00:22 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10541139/6003

8 years, 6 months ago (2012-06-14 17:02:11 UTC) #10

Change committed as 142209