Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 10541127: Fix and re-enable AcceleratorControllerTest.GlobalAccelerator. (Closed)

Created:
8 years, 6 months ago by mazda
Modified:
8 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix and re-enable AcceleratorControllerTest.GlobalAccelerator. BUG=127538 TEST=aura_shell_unittests --gtest_filter="AcceleratorControllerTest.GlobalAccelerator" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141779

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 5 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mazda
8 years, 6 months ago (2012-06-12 21:44:27 UTC) #1
Daniel Erat
lgtm http://codereview.chromium.org/10541127/diff/1/ash/accelerators/accelerator_controller_unittest.cc File ash/accelerators/accelerator_controller_unittest.cc (right): http://codereview.chromium.org/10541127/diff/1/ash/accelerators/accelerator_controller_unittest.cc#newcode745 ash/accelerators/accelerator_controller_unittest.cc:745: // tested before the sentence below is invoked ...
8 years, 6 months ago (2012-06-12 21:46:20 UTC) #2
mazda
http://codereview.chromium.org/10541127/diff/1/ash/accelerators/accelerator_controller_unittest.cc File ash/accelerators/accelerator_controller_unittest.cc (right): http://codereview.chromium.org/10541127/diff/1/ash/accelerators/accelerator_controller_unittest.cc#newcode745 ash/accelerators/accelerator_controller_unittest.cc:745: // tested before the sentence below is invoked because ...
8 years, 6 months ago (2012-06-12 21:55:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10541127/7001
8 years, 6 months ago (2012-06-12 21:55:58 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 23:11:06 UTC) #5
Change committed as 141779

Powered by Google App Engine
This is Rietveld 408576698