Add "scheme" field to WebIntentServiceData object.

Add "scheme" field to WebIntentServiceData object.
Add unittest for web_intent_service_data.
Reorder constructor args to group service url with title.

BUG=129199
TEST=./out/Debug/unit_tests --gtest_filter=WebIntentServiceDataTest.*

+jamesr AND brettw for webkit_glue changes.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144800

[Greg Billock, 2012-06-14 05:06:52]

lgtm

[commit-bot: I haz the power, 2012-06-14 16:07:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/smckay@chromium.org/10541125/1

[commit-bot: I haz the power, 2012-06-14 16:07:17]

Presubmit check for 10541125-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit

[Steve McKay, 2012-06-14 16:42:49]

Added OWNERS for webkit to LGTM webkit_glue changes. jamesr@ OR brettw@, if one
of you would kindly review :)

[jamesr, 2012-06-14 18:15:37]

Is "scheme" here something different from a URL scheme? It's a bit confusing to
me to see a GURL and a scheme next to each other in a parameter list since GURLs
have a scheme

[Steve McKay, 2012-06-14 18:52:50]

On 2012/06/14 18:15:37, jamesr wrote:
> Is "scheme" here something different from a URL scheme? It's a bit confusing
to
> me to see a GURL and a scheme next to each other in a parameter list since
GURLs
> have a scheme

Sorry, I threw this at you out of the blue without much context. It also hurts
us a bit that there are so many strings in the WebIntentServiceData interface.

In this case "scheme" refers to a URL scheme that is a component of a service
registration (web intent service). The registration can be matched when a caller
invokes an intent that specifies a scheme (e.g. mailto), or by action +
[mime_]type (e.g. http://webintents.org/pick, image/png).

Basically we're add protocol-handler style support to web intents. In a followup
CL I'll be reimplementing registerProtocolHandler support on top of WebIntents
(thus sharing registrations made between the two).

[jamesr, 2012-06-14 19:14:53]

On 2012/06/14 18:52:50, smckay1 wrote:
> On 2012/06/14 18:15:37, jamesr wrote:
> > Is "scheme" here something different from a URL scheme? It's a bit confusing
> to
> > me to see a GURL and a scheme next to each other in a parameter list since
> GURLs
> > have a scheme
> 
> Sorry, I threw this at you out of the blue without much context. It also hurts
> us a bit that there are so many strings in the WebIntentServiceData interface.
> 
> In this case "scheme" refers to a URL scheme that is a component of a service
> registration (web intent service). The registration can be matched when a
caller
> invokes an intent that specifies a scheme (e.g. mailto), or by action +
> [mime_]type (e.g. http://webintents.org/pick, image/png).

So it is a URL scheme, but it's not the service_url's scheme?
> 
> Basically we're add protocol-handler style support to web intents. In a
followup
> CL I'll be reimplementing registerProtocolHandler support on top of WebIntents
> (thus sharing registrations made between the two).

[smckay, 2012-06-14 19:36:34]

Correct. It is entirely unrelated to the service URL. I actually reordered
the fields/constructor args to group the service url next to the title
(which is for the service_url) and to put a GURL between some of the MANY
strings, but grouping it next to the GURL may cause confusion. I'll update
the comments to make this clear, then ping for review.

A nice way to reorganize things if we're not going to introduce sub-classes
of WebIntentServiceData would be to have a small IntentKey type hierarchy
(IntentKey: ActionIntentKey, SchemeIntentKey). Might be a nice way to
compose things and make the api more self-documenting.

Steve McKay | Sr. Software Engineer | smckay@google.com | 310-359-8331




On Thu, Jun 14, 2012 at 12:14 PM, <jamesr@chromium.org> wrote:

> On 2012/06/14 18:52:50, smckay1 wrote:
>
>> On 2012/06/14 18:15:37, jamesr wrote:
>> > Is "scheme" here something different from a URL scheme? It's a bit
>> confusing
>> to
>> > me to see a GURL and a scheme next to each other in a parameter list
>> since
>> GURLs
>> > have a scheme
>>
>
>  Sorry, I threw this at you out of the blue without much context. It also
>> hurts
>> us a bit that there are so many strings in the WebIntentServiceData
>> interface.
>>
>
>  In this case "scheme" refers to a URL scheme that is a component of a
>> service
>> registration (web intent service). The registration can be matched when a
>>
> caller
>
>> invokes an intent that specifies a scheme (e.g. mailto), or by action +
>> [mime_]type (e.g. http://webintents.org/pick, image/png).
>>
>
> So it is a URL scheme, but it's not the service_url's scheme?
>
>
>  Basically we're add protocol-handler style support to web intents. In a
>>
> followup
>
>> CL I'll be reimplementing registerProtocolHandler support on top of
>> WebIntents
>> (thus sharing registrations made between the two).
>>
>
>
>
>
https://chromiumcodereview.**appspot.com/10541125/<https://chromiumcodereview...
>

[Steve McKay, 2012-06-22 19:16:59]

I don't think the CL is waiting on me. Can folks have another look?

[Steve McKay, 2012-06-22 19:18:51]

Woops. I am responsible for updating the comments. I'll ping when the CL is
ready.

[Steve McKay, 2012-06-22 19:22:33]

Okay. Updated the comments. PTAL.

[Greg Billock, 2012-06-25 16:33:16]

On 2012/06/22 19:22:33, smckay1 wrote:
> Okay. Updated the comments. PTAL.

Can you update content/common/intents_messages.h as well to add the scheme
field?

[Steve McKay, 2012-06-27 22:44:13]

PTAL.

I reordered the IPC traits, but don't know for sure that's kosher. Lemme know.

WebKit folks in particular. Please have a look.

[brettw, 2012-06-27 22:46:17]

It's fine to reorder the traits.

[jamesr, 2012-06-27 23:24:28]

lgtm

[commit-bot: I haz the power, 2012-06-28 00:49:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/smckay@chromium.org/10541125/28002

[commit-bot: I haz the power, 2012-06-28 00:49:44]

Presubmit check for 10541125-28002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common

Presubmit checks took 1.3s to calculate.

[brettw, 2012-06-28 19:05:55]

content/common LGTM

[commit-bot: I haz the power, 2012-06-28 20:18:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/smckay@chromium.org/10541125/28002

[commit-bot: I haz the power, 2012-06-28 21:24:45]

Change committed as 144800