Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 10541122: Abort: change the magic value written to NULL (Closed)

Created:
8 years, 6 months ago by jln (very slow on Chromium)
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Abort: change the magic value written to NULL Make sure that the magic value can be cast to a char properly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/tcmalloc/chromium/src/base/abort.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
We could not write 0x2001 properly as it does not fit in a char and ...
8 years, 6 months ago (2012-06-12 20:36:43 UTC) #1
kaiwang
lgtm Thanks for your fix. You may need to find a owner to LG though...
8 years, 6 months ago (2012-06-12 21:13:29 UTC) #2
jln (very slow on Chromium)
On 2012/06/12 21:13:29, kaiwang wrote: > lgtm > > Thanks for your fix. > You ...
8 years, 6 months ago (2012-06-12 21:47:32 UTC) #3
jar (doing other things)
The goal is to generate a segv..... so any value, even zero, will work... but ...
8 years, 6 months ago (2012-06-12 22:12:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10541122/1
8 years, 6 months ago (2012-06-12 22:26:14 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 00:49:02 UTC) #6
Change committed as 141814

Powered by Google App Engine
This is Rietveld 408576698