Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: webkit/plugins/ppapi/plugin_delegate.h

Issue 10541113: Notify CloseFile from Pepper to FileSystem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/mock_plugin_delegate.cc ('k') | webkit/plugins/ppapi/ppb_file_io_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/plugin_delegate.h
diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h
index 545afa4e68e89d1cf2436c9ad44c1ac849a8c5db..7ba136e2647728992a5af1d6bbc58b9e905792da 100644
--- a/webkit/plugins/ppapi/plugin_delegate.h
+++ b/webkit/plugins/ppapi/plugin_delegate.h
@@ -422,16 +422,29 @@ class PluginDelegate {
const WebKit::WebFileChooserParams& params,
WebKit::WebFileChooserCompletion* chooser_completion) = 0;
- // Sends an async IPC to open a file.
+ // Sends an async IPC to open a local file.
typedef base::Callback<void (base::PlatformFileError, base::PassPlatformFile)>
AsyncOpenFileCallback;
virtual bool AsyncOpenFile(const FilePath& path,
int flags,
const AsyncOpenFileCallback& callback) = 0;
+
+ // Sends an async IPC to open a file through filesystem API.
+ // When a file is successfully opened, |callback| is invoked with
+ // PLATFORM_FILE_OK, the opened file handle, and a callback function for
+ // notifying that the file is closed. When the users of this function
+ // finished using the file, they must close the file handle and then must call
+ // the supplied callback function.
+ typedef base::Callback<void (base::PlatformFileError)>
+ NotifyCloseFileCallback;
+ typedef base::Callback<
+ void (base::PlatformFileError,
+ base::PassPlatformFile,
+ const NotifyCloseFileCallback&)> AsyncOpenFileSystemURLCallback;
virtual bool AsyncOpenFileSystemURL(
const GURL& path,
int flags,
- const AsyncOpenFileCallback& callback) = 0;
+ const AsyncOpenFileSystemURLCallback& callback) = 0;
virtual bool OpenFileSystem(
const GURL& url,
« no previous file with comments | « webkit/plugins/ppapi/mock_plugin_delegate.cc ('k') | webkit/plugins/ppapi/ppb_file_io_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698