Issue 10541109: Implement active window list for platform apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10541109: Implement active window list for platform apps (Closed)

Created:
8 years, 6 months ago by DaveMoore

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement active window list BUG=131878 TEST=Existing and new LauncherPlatformAppBrowserTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141656

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Patch Set 3 : Minor cleanup #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -13 lines)			Patch
M	chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.h	View	1 2	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc	View	1	4 chunks	+31 lines, -13 lines	1 comment	Download
M	chrome/browser/ui/views/ash/launcher/launcher_platform_app_browsertest.cc	View		1 chunk	+79 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 6 months ago (2012-06-12 04:32:11 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10541109/diff/3001/chrome/browser/ui/v...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc (right):

https://chromiumcodereview.appspot.com/10541109/diff/3001/chrome/browser/ui/v...
chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc:237: i !=
activation_order_.end(); ++i) {
nit: indent one more space.

https://chromiumcodereview.appspot.com/10541109/diff/3001/chrome/browser/ui/v...
File chrome/browser/ui/views/ash/launcher/launcher_platform_app_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/10541109/diff/3001/chrome/browser/ui/v...
chrome/browser/ui/views/ash/launcher/launcher_platform_app_browsertest.cc:186:
ASSERT_EQ(ash::TYPE_PLATFORM_APP, item1.type);
EXPECT_EQ is fine here and almost all of these. Use ASSERT when continuing on
would trigger a crash (like 183 if the item_count is wrong).

Expand Messages | Collapse Messages