Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 10541088: Propogate the UI language on the command line and expose to Flash. (Closed)

Created:
8 years, 6 months ago by brettw
Modified:
8 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Propogate the UI language on the command line and expose to Flash. This is just like the NPAPI plugin process and many of the other child processes we have. I wire the command line parameter up to a new Flash setting. TEST=manual BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141434

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_flash.idl View 1 1 chunk +10 lines, -1 line 0 comments Download
M ppapi/c/private/ppb_flash.h View 1 2 chunks +10 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_proxy_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
https://chromiumcodereview.appspot.com/10541088/diff/6002/content/browser/ppapi_plugin_process_host.cc File content/browser/ppapi_plugin_process_host.cc (right): https://chromiumcodereview.appspot.com/10541088/diff/6002/content/browser/ppapi_plugin_process_host.cc#newcode195 content/browser/ppapi_plugin_process_host.cc:195: content::GetContentClient()->browser()->GetApplicationLocale(); This runs on the I/O thread and you ...
8 years, 6 months ago (2012-06-08 22:58:40 UTC) #1
viettrungluu
8 years, 6 months ago (2012-06-11 17:18:50 UTC) #2
LGTM, I guess, where "G" may be an overstatement given your comments.

Powered by Google App Engine
This is Rietveld 408576698