Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 10541085: When persisting UMA logs to disk, cap log size based on both the XML and protocol buffer logs. (Closed)

Created:
8 years, 6 months ago by Ilya Sherman
Modified:
8 years, 6 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Visibility:
Public.

Description

When persisting UMA logs to disk, cap log size based on both the XML and protocol buffer logs. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141550

Patch Set 1 #

Patch Set 2 : max rather than sum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/metrics/metrics_log_serializer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/metrics/metrics_log_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/metrics/metrics_log_manager.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
Currently adding the log sizes; but if the size cap is more of an arbitrary ...
8 years, 6 months ago (2012-06-08 22:25:10 UTC) #1
stuartmorgan
I picked the numbers based on some sizes of actual logs, trying to pick something ...
8 years, 6 months ago (2012-06-11 07:57:04 UTC) #2
jar (doing other things)
lgtm
8 years, 6 months ago (2012-06-11 08:07:11 UTC) #3
Ilya Sherman
Switched to max rather than sum, committing.
8 years, 6 months ago (2012-06-11 22:07:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10541085/1004
8 years, 6 months ago (2012-06-11 22:08:01 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-11 23:15:43 UTC) #6
Change committed as 141550

Powered by Google App Engine
This is Rietveld 408576698