Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 10541073: enable android GetMimeTypeFromExtention in mime_util (Closed)

Created:
8 years, 6 months ago by Wei James(wistoch)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

enable android GetMimeTypeFromExtention in mime_util corresponding JNI code already in upstream, this function can be enabled so. BUG=131804 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M net/base/platform_mime_util_linux.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Wei James(wistoch)
8 years, 6 months ago (2012-06-08 15:50:29 UTC) #1
Wei James(wistoch)
8 years, 6 months ago (2012-06-08 15:50:29 UTC) #2
Wei James(wistoch)
8 years, 6 months ago (2012-06-08 15:50:29 UTC) #3
John Grabowski
LGTM from Android. jar: please provide OWNERS review for this change.
8 years, 6 months ago (2012-06-08 17:13:19 UTC) #4
jar (doing other things)
LGTM
8 years, 6 months ago (2012-06-11 17:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10541073/1
8 years, 6 months ago (2012-06-11 23:07:01 UTC) #6
commit-bot: I haz the power
Change committed as 141574
8 years, 6 months ago (2012-06-12 00:33:33 UTC) #7
nilesh
On 2012/06/12 00:33:33, I haz the power (commit-bot) wrote: > Change committed as 141574 I ...
8 years, 6 months ago (2012-06-12 04:23:15 UTC) #8
nilesh
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Android/builds/10202 On Mon, Jun 11, 2012 at 9:23 PM, <nileshagrawal@chromium.org> wrote: > On 2012/06/12 00:33:33, ...
8 years, 6 months ago (2012-06-12 04:25:22 UTC) #9
Wei James(wistoch)
Thanks for the notification. I will disable the tests firstly. Best Regards James From: nileshagrawal@google.com ...
8 years, 6 months ago (2012-06-12 04:32:46 UTC) #10
Wei James(wistoch)
8 years, 6 months ago (2012-06-12 05:03:02 UTC) #11
https://chromiumcodereview.appspot.com/10533103/ 

disable 5 test cases related with GetMimeTypeFromExtension. 

thansk

Powered by Google App Engine
This is Rietveld 408576698