Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 10541066: Add JniHelper into content_jni_registrar (Closed)

Created:
8 years, 6 months ago by haitao.feng
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch-content_chromium.org, yongsheng, Shouqun Liu
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add JniHelper into content_jni_registrar BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/app/android/content_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
haitao.feng
It is quite interesting that the include files are in alphabetical order, so I keep ...
8 years, 6 months ago (2012-06-08 01:08:28 UTC) #1
John Grabowski
LGTM
8 years, 6 months ago (2012-06-08 01:14:30 UTC) #2
Ted C
lgtm lgtm
8 years, 6 months ago (2012-06-08 01:22:25 UTC) #3
jam
(don't need my review since you already have owner review from content/app/android/OWNERS)
8 years, 6 months ago (2012-06-08 01:45:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitao.feng@intel.com/10541066/1
8 years, 6 months ago (2012-06-08 01:46:56 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 02:39:36 UTC) #6
Change committed as 141162

Powered by Google App Engine
This is Rietveld 408576698