Adds NetworkDelegate::NotifyBeforeSocketStreamConnect()

Adds NetworkDelegate::NotifyBeforeSocketStreamConnect()

This function will be called before an WebSocket tries to connect.
This function can do extra work such as policy checks to prevent the connect.

ChromeNetworkDelegate implements the function to check URL blacklist.

BUG=131046
TEST=net_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141816

[bashi, 2012-06-07 05:00:07]

Hi willchan, wtc, toyoshim,

Could you take a look?

[willchan no longer on Chromium, 2012-06-07 23:07:07]

+joaodasilva for policy/

We probably should update the URLBlacklistManager tests to make sure it works
with ws/wss.

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/socket_stream/s...
File net/socket_stream/socket_stream.h (right):

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/socket_stream/s...
net/socket_stream/socket_stream.h:317: void BeforeConnectComplete(int result);
Please follow the existing convention. Pass the io_callback_ instead of creating
a new before_connect_callback_, and rename this to DoBeforeConnectComplete().

I'm also not fond of the name of DoBeforeConnect(), but I don't have a better
suggestion :P

[Joao da Silva, 2012-06-07 23:18:33]

policy/ lgtm.

We're currently working on improving the end-to-end test coverage of the
enterprise code. If this lands I'll extend the URL blacklisting pyauto test to
also verify that websockets are blocked/allowed.

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/base/network_de...
File net/base/network_delegate.cc (right):

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/base/network_de...
net/base/network_delegate.cc:125: 
Nit: one newline

[bashi, 2012-06-08 02:48:33]

Thank you for review!

I rebased the CL and addressed comments. I also updated URLBlacklistManagerTest.
PTAL?

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/base/network_de...
File net/base/network_delegate.cc (right):

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/base/network_de...
net/base/network_delegate.cc:125: 
On 2012/06/07 23:18:34, Joao da Silva wrote:
> Nit: one newline

Removed.

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/socket_stream/s...
File net/socket_stream/socket_stream.h (right):

https://chromiumcodereview.appspot.com/10541046/diff/8001/net/socket_stream/s...
net/socket_stream/socket_stream.h:317: void BeforeConnectComplete(int result);
On 2012/06/07 23:07:07, willchan wrote:
> Please follow the existing convention. Pass the io_callback_ instead of
creating
> a new before_connect_callback_, and rename this to DoBeforeConnectComplete().
> 
> I'm also not fond of the name of DoBeforeConnect(), but I don't have a better
> suggestion :P

Done.

[willchan no longer on Chromium, 2012-06-08 23:34:45]

lgtm

[commit-bot: I haz the power, 2012-06-10 23:04:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bashi@chromium.org/10541046/10002

[commit-bot: I haz the power, 2012-06-10 23:04:39]

Presubmit check for 10541046-10002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit
    content

Presubmit checks took 1.8s to calculate.

[bashi, 2012-06-10 23:08:29]

Adding tony@ and avi@ for webkit/ and content/

[tony, 2012-06-11 16:59:21]

webkit LGTM

[bashi, 2012-06-12 23:04:13]

Adding folks for content/ review.

[darin (slow to review), 2012-06-12 23:45:27]

LGTM

[commit-bot: I haz the power, 2012-06-12 23:49:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bashi@chromium.org/10541046/10002

[commit-bot: I haz the power, 2012-06-13 00:54:04]

Change committed as 141816

[brettw, 2012-06-13 02:12:16]

Please only add one OWNER to avoid sending unnecessary review requests.