Issue 10541045: Move ScoredHistoryMatch into Its Own Set of Files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10541045: Move ScoredHistoryMatch into Its Own Set of Files (Closed)

Created:
8 years, 6 months ago by mrossetti

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, James Su, brettw-cc_chromium.org, Mark P, Peter Kasting

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move ScoredHistoryMatch into Its Own Set of Files Created scored_history_match.h/cc and moved the ScoredHistoryMatch struct therein. Moved all scoring functions into that struct. Created scored_history_match_unittest.cc and moved scoring tests therein. BUG=None TEST=All unit tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141004

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+891 lines, -607 lines)			Patch
M	chrome/browser/autocomplete/history_quick_provider.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/history/in_memory_url_index.h	View	2 chunks	+1 line, -18 lines	0 comments	Download
M	chrome/browser/history/in_memory_url_index_types.h	View	3 chunks	+23 lines, -21 lines	0 comments	Download
M	chrome/browser/history/in_memory_url_index_types.cc	View	3 chunks	+18 lines, -20 lines	0 comments	Download
M	chrome/browser/history/in_memory_url_index_unittest.cc	View	7 chunks	+25 lines, -22 lines	0 comments	Download
A	chrome/browser/history/scored_history_match.h	View	1 chunk	+140 lines, -0 lines	0 comments	Download
A	chrome/browser/history/scored_history_match.cc	View	1 chunk	+472 lines, -0 lines	0 comments	Download
A	chrome/browser/history/scored_history_match_unittest.cc	View	1 chunk	+199 lines, -0 lines	0 comments	Download
M	chrome/browser/history/url_index_private_data.h	View	5 chunks	+3 lines, -84 lines	0 comments	Download
M	chrome/browser/history/url_index_private_data.cc	View	5 chunks	+2 lines, -442 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mrossetti

This is a rearranging of source code only. I have made no implementation changes other ...

8 years, 6 months ago (2012-06-07 02:02:00 UTC) #1

LGTM

Expand Messages | Collapse Messages