Show account part of the display email when real name is not available.

Show account part of the display email when real name is not available.
And add better handling of corner case failures.

TBR=davemoore@chromium.org (for chrome/browser/chromeos/cros/onc_network_parser.cc)
BUG=131630
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141241

[Emmanuel Saint-loubert-Bié, 2012-06-06 20:49:58]

Hi Nikita,

The change you suggested. I asked my local build to test it and it works when
there is no real name retrieved.

-- Emmanuel

[Nikita (slow), 2012-06-08 11:40:58]

lgtm

http://codereview.chromium.org/10541036/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

http://codereview.chromium.org/10541036/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/user_manager_impl.cc:292:
SetInitialUserImage(email);
We should save default display name (email account) till real name is
downloaded. Should fix http://code.google.com/p/chromium/issues/detail?id=131630

SaveUserDisplayName(GetLoggedInUser().email(),
  UTF8ToUTF16(GetLoggedInUser().GetAccountName(true)));

http://codereview.chromium.org/10541036/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/user_manager_impl.cc:1383: result =
kDownloadFailure;
SaveUserDisplayName(GetLoggedInUser().email(),
  UTF8ToUTF16(GetLoggedInUser().GetAccountName(true)));

[Emmanuel Saint-loubert-Bié, 2012-06-08 16:55:21]

Thanks for the comments Nikita!

http://codereview.chromium.org/10541036/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

http://codereview.chromium.org/10541036/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/user_manager_impl.cc:292:
SetInitialUserImage(email);
On 2012/06/08 11:40:59, Nikita Kostylev wrote:
> We should save default display name (email account) till real name is
> downloaded. Should fix
http://code.google.com/p/chromium/issues/detail?id=131630
> 
> SaveUserDisplayName(GetLoggedInUser().email(),
>   UTF8ToUTF16(GetLoggedInUser().GetAccountName(true)));

Done.

http://codereview.chromium.org/10541036/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/user_manager_impl.cc:1383: result =
kDownloadFailure;
On 2012/06/08 11:40:59, Nikita Kostylev wrote:
> SaveUserDisplayName(GetLoggedInUser().email(),
>   UTF8ToUTF16(GetLoggedInUser().GetAccountName(true)));

Done.

[commit-bot: I haz the power, 2012-06-08 16:55:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/10541036/8001

[commit-bot: I haz the power, 2012-06-08 18:19:40]

Change committed as 141241