Adding a field trial for testing --force-compositing-mode on 50% of

chrome/browser/browser_trial.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // BrowserTrial contains methods specific to field trials (using FieldTrial
 // functionality) for browser tests.
 
 #ifndef CHROME_BROWSER_BROWSER_TRIAL_H_
 #define CHROME_BROWSER_BROWSER_TRIAL_H_
 #pragma once
 
 #include "base/basictypes.h"
 
 // Currently we use this as a name space, to hold static shared constants which
 // define current and past trials.
 class BrowserTrial {
  public:
 
   // The following is a sample line for what should be listed in this file.
-  // static const wchar_t* kPruningAlgorithmFieldTrial;
+  // static const char* kPruningAlgorithmFieldTrial;
+
+  // Field trial for force-compositing-mode.
+  static const char* kForceCompositingModeTrial;

[Ilya Sherman, 2012/06/06 09:50:21]

nit: Jim might correct me, but I don't think this file is actually meant to be
used as a central repository anymore.  If there's another natural place where
you would have put this constant had this file not existed, that might be a more
appropriate choice.  If not, I guess this location should be fine.

[jar (doing other things), 2012/06/06 18:16:52]

+1

I had to look back at the history... and this was last used in 2008.... and it
should probably be swept away (as it has not had a demonstrable reason to exist
since then).

Note that this header won't be visible in renderer processes... so it has
especially limited (potential) use.

Reading the logs, it looks like this was intended to grow into a central area
kindred to what Finch is currently chasing after (with UMA remote control over
field trials).  I think Finch has its own plan... which further deprecates this
file's usage :-/.

Sorry for the confusion caused by its presence.


On 2012/06/06 09:50:21, Ilya Sherman wrote:

 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserTrial);
 };
 
 #endif  // CHROME_BROWSER_BROWSER_TRIAL_H_