Issue 10541007: [cros] Pre-select the first user pod on login screen.

Issue 10541007: [cros] Pre-select the first user pod on login screen. (Closed)

Created:
8 years, 6 months ago by Ivan Korotkov

Modified:
8 years, 6 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Pre-select the first user pod on login screen. *) Some JS style cleanup. *) When no pod was previously selected, wallpaper is loaded immediately. BUG=131160 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140750

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added conditional flag to preselect first pod. #

Patch Set 3 : Merge #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -10 lines)			Patch
	M	chrome/browser/resources/chromeos/login/screen_account_picker.js	View	1 2	3 chunks	+16 lines, -7 lines	0 comments	Download
	M	chrome/browser/resources/chromeos/login/user_pod_row.js	View		1 chunk	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm http://codereview.chromium.org/10541007/diff/1/chrome/browser/resources/chromeos/login/screen_account_picker.js File chrome/browser/resources/chromeos/login/screen_account_picker.js (right): http://codereview.chromium.org/10541007/diff/1/chrome/browser/resources/chromeos/login/screen_account_picker.js#newcode70 chrome/browser/resources/chromeos/login/screen_account_picker.js:70: var preselectedPod = lockedPod || podRow.pods[0]; nit: Please ...

8 years, 6 months ago (2012-06-06 09:40:04 UTC) #2

Ivan Korotkov

http://codereview.chromium.org/10541007/diff/1/chrome/browser/resources/chromeos/login/screen_account_picker.js File chrome/browser/resources/chromeos/login/screen_account_picker.js (right): http://codereview.chromium.org/10541007/diff/1/chrome/browser/resources/chromeos/login/screen_account_picker.js#newcode70 chrome/browser/resources/chromeos/login/screen_account_picker.js:70: var preselectedPod = lockedPod || podRow.pods[0]; On 2012/06/06 09:40:04, ...

8 years, 6 months ago (2012-06-06 10:59:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10541007/3001

8 years, 6 months ago (2012-06-06 11:00:25 UTC) #4

commit-bot: I haz the power

Failed to apply patch for chrome/browser/resources/chromeos/login/screen_account_picker.js: While running patch -p1 --forward --force; patching file chrome/browser/resources/chromeos/login/screen_account_picker.js ...

8 years, 6 months ago (2012-06-06 11:00:26 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10541007/6001

8 years, 6 months ago (2012-06-06 11:07:07 UTC) #6

Change committed as 140750

Expand Messages | Collapse Messages