Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10540175: Fix DataView constructor and byte accessors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/generator.py ('k') | lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index afb1c3e30613ddb91bc90f923d246f7652f9cde5..ca0598c60b2b2753d8f60a12a0640dbb5a219951 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -255,7 +255,7 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
if constructor_info:
self._EmitFactoryProvider(self._interface.id, constructor_info)
- if constructor_info is None:
+ if 'CustomConstructor' in self._interface.ext_attrs:
# We have a custom implementation for it.
self._cpp_declarations_emitter.Emit(
'\n'
« no previous file with comments | « lib/dom/scripts/generator.py ('k') | lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698