Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: nss/mozilla/security/nss/lib/pki/pkibase.c

Issue 10540165: Update NSS to NSS 3.13.5 (from NSS 3.13.3). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: nss/mozilla/security/nss/lib/pki/pkibase.c
===================================================================
--- nss/mozilla/security/nss/lib/pki/pkibase.c (revision 142244)
+++ nss/mozilla/security/nss/lib/pki/pkibase.c (working copy)
@@ -35,7 +35,7 @@
* ***** END LICENSE BLOCK ***** */
#ifdef DEBUG
-static const char CVS_ID[] = "@(#) $RCSfile: pkibase.c,v $ $Revision: 1.33 $ $Date: 2010/04/03 18:27:32 $";
+static const char CVS_ID[] = "@(#) $RCSfile: pkibase.c,v $ $Revision: 1.33.6.1 $ $Date: 2012/05/17 21:40:54 $";
#endif /* DEBUG */
#ifndef DEV_H
@@ -364,8 +364,8 @@
if ((!tokenOpt && object->instances[i]->label) ||
(object->instances[i]->token == tokenOpt))
{
- /* XXX should be copy? safe as long as caller has reference */
- nickname = object->instances[i]->label;
+ /* Must copy, see bug 745548 */
+ nickname = nssUTF8_Duplicate(object->instances[i]->label, NULL);
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698