Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: nss/mozilla/security/nss/lib/libpkix/pkix/checker/pkix_signaturechecker.c

Issue 10540165: Update NSS to NSS 3.13.5 (from NSS 3.13.3). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: nss/mozilla/security/nss/lib/libpkix/pkix/checker/pkix_signaturechecker.c
===================================================================
--- nss/mozilla/security/nss/lib/libpkix/pkix/checker/pkix_signaturechecker.c (revision 142244)
+++ nss/mozilla/security/nss/lib/libpkix/pkix/checker/pkix_signaturechecker.c (working copy)
@@ -245,7 +245,6 @@
certVerified = PKIX_TRUE;
} else {
certVerified = PKIX_FALSE;
- PKIX_DECREF(verifyFail);
}
}
@@ -292,6 +291,7 @@
plContext),
PKIX_LISTGETITEMFAILED);
+ PKIX_DECREF(verifyFail);
verifyFail = PKIX_PL_Cert_VerifySignature
(cert, pKey, plContext);
@@ -300,7 +300,6 @@
break;
} else {
certVerified = PKIX_FALSE;
- PKIX_DECREF(verifyFail);
}
PKIX_DECREF(pKey);
@@ -309,6 +308,8 @@
#endif
if (certVerified == PKIX_FALSE) {
+ pkixErrorResult = verifyFail;
+ verifyFail = NULL;
PKIX_ERROR(PKIX_VALIDATIONFAILEDCERTSIGNATURECHECKING);
}

Powered by Google App Engine
This is Rietveld 408576698