Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10540128: don't try to call BalloonViewHost on non-cros (Closed)

Created:
8 years, 6 months ago by scottmg
Modified:
8 years, 6 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

don't try to call BalloonViewHost on non-cros Avoids link error: [14->2/16 ~0] LINK(DLL) initial\chrome.dll FAILED: python gyp-win-tool link-wrapper "c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\link.exe" /nologo /IMPLIB:initial\chrome.dll.lib /DLL /OUT:initial\chrome.dll /PDB:initial\chrome.dll.pdb @initial\chrome.dll.rsp browser.balloon_collection_impl_ash.obj : error LNK2019: unresolved external symbol "public: bool __thiscall chromeos::BalloonViewHost::AddWebUIMessageCallback(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::Callback<void __cdecl(class base::ListValue const *)> const &)" (?AddWebUIMessageCallback@BalloonViewHost@chromeos@@QAE_NABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABV?$Callback@$$A6AXPBVListValue@base@@@Z@base@@@Z) referenced in function "public: bool __thiscall BalloonCollectionImplAsh::AddWebUIMessageCallback(class Notification const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::Callback<void __cdecl(class base::ListValue const *)> const &)" (?AddWebUIMessageCallback@BalloonCollectionImplAsh@@QAE_NABVNotification@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABV?$Callback@$$A6AXPBVListValue@base@@@Z@base@@@Z) initial\chrome.dll : fatal error LNK1120: 1 unresolved externals R=ben@chromium.org,cpu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/views/ash/balloon_collection_impl_ash.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
I have no idea if this is the correct fix, but alternatively we need something ...
8 years, 6 months ago (2012-06-12 21:46:36 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 6 months ago (2012-06-12 22:17:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10540128/1
8 years, 6 months ago (2012-06-12 22:18:54 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 23:41:21 UTC) #4
Change committed as 141789

Powered by Google App Engine
This is Rietveld 408576698