Add API to configure debugger pause on exception

runtime/vm/debugger.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/debugger.h"
 
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 459 matching lines @@
       bp_handler_(NULL),
       event_handler_(NULL),
       next_id_(1),
       stack_trace_(NULL),
       obj_cache_(NULL),
       src_breakpoints_(NULL),
       code_breakpoints_(NULL),
       resume_action_(kContinue),
       last_bpt_line_(-1),
       ignore_breakpoints_(false),
-      pause_on_exception_(false),
-      pause_on_unhandled_exception_(false) {
+      exc_pause_info_(kNoPauseOnExceptions) {
 }
 
 
 Debugger::~Debugger() {
   ASSERT(src_breakpoints_ == NULL);
   ASSERT(code_breakpoints_ == NULL);
   ASSERT(stack_trace_ == NULL);
   ASSERT(obj_cache_ == NULL);
 }
 
@@ skipping 125 matching lines @@
     ASSERT(frame->IsDartFrame());
     ActivationFrame* activation =
         new ActivationFrame(frame->pc(), frame->fp(), frame->sp());
     stack_trace->AddActivation(activation);
     frame = iterator.NextFrame();
   }
   return stack_trace;
 }
 
 
-// TODO(hausner): Determine whether the exception is handled or not, and
-// check with the settings the user specified to determine whether the
-// debugger should pause or not.
-// For now, we just pause on TypeError and AssertionError exceptions.
-bool Debugger::ShouldPauseOnException(DebuggerStackTrace* stack_trace,
-                                      const Object& exc) {
-  const Class& exc_class = Class::Handle(exc.clazz());
-  const String& class_name = String::Handle(exc_class.Name());
-  // TODO(hausner): Note the poor man's type test. Replace with check for
-  // actual class object or class id.
-  return class_name.Equals("TypeError") || class_name.Equals("AssertionError");
+void Debugger::SetExceptionPauseInfo(Dart_ExceptionPauseInfo pause_info) {
+  exc_pause_info_ = pause_info;
 }
 
 
+// TODO(hausner): Determine whether the exception is handled or not.
+bool Debugger::ShouldPauseOnException(DebuggerStackTrace* stack_trace,
+                                      const Object& exc) {
+  if (exc_pause_info_ == kNoPauseOnExceptions) {
+    return false;
+  }
+  if ((exc_pause_info_ & kPauseOnAllExceptions) != 0) {
+    return true;
+  }
+  // Assume TypeError and AssertionError exceptions are unhandled.
+  const Class& exc_class = Class::Handle(exc.clazz());
+  const String& class_name = String::Handle(exc_class.Name());
+  // TODO(hausner): Note the poor man's type test. This code will go
+  // away when we have a way to determine whether an exception is unhandled.
+  if (class_name.Equals("TypeError")) {
+    return true;
+  }
+  if (class_name.Equals("AssertionError")) {
+    return true;
+  }
+  return false;
+}
+
+
 void Debugger::SignalExceptionThrown(const Object& exc) {
   if (ignore_breakpoints_) {
     return;
   }
   DebuggerStackTrace* stack_trace = CollectStackTrace();
   if (!ShouldPauseOnException(stack_trace, exc)) {
     return;
   }
   // No single-stepping possible after this pause event.
   last_bpt_line_ = -1;
@@ skipping 670 matching lines @@
 }
 
 
 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
   ASSERT(bpt->next() == NULL);
   bpt->set_next(code_breakpoints_);
   code_breakpoints_ = bpt;
 }
 
 }  // namespace dart