Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: lib/html/frog/html_frog.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 10540110: Put width before height in element constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/frog/html_frog.dart
diff --git a/lib/html/frog/html_frog.dart b/lib/html/frog/html_frog.dart
index eb03cd588cee0f6380ab76135baa318425d479ed..4bff43aa16ab4f388825685370483ca7bde6a6d5 100644
--- a/lib/html/frog/html_frog.dart
+++ b/lib/html/frog/html_frog.dart
@@ -17136,10 +17136,10 @@ class _Elements {
return _e;
}
- factory CanvasElement([int height, int width]) {
+ factory CanvasElement([int width, int height]) {
_CanvasElementImpl _e = _document.$dom_createElement("canvas");
- if (height != null) _e.height = height;
if (width != null) _e.width = width;
+ if (height != null) _e.height = height;
return _e;
}
@@ -17218,11 +17218,11 @@ class _Elements {
return _e;
}
- factory ImageElement([String src, int height, int width]) {
+ factory ImageElement([String src, int width, int height]) {
_ImageElementImpl _e = _document.$dom_createElement("img");
if (src != null) _e.src = src;
- if (height != null) _e.height = height;
if (width != null) _e.width = width;
+ if (height != null) _e.height = height;
return _e;
}
@@ -21040,7 +21040,7 @@ interface CSSValueList extends CSSValue {
/// @domName HTMLCanvasElement
interface CanvasElement extends Element default _Elements {
- CanvasElement([int height, int width]);
+ CanvasElement([int width, int height]);
/** @domName HTMLCanvasElement.height */
int height;
@@ -25100,7 +25100,7 @@ interface ImageData {
/// @domName HTMLImageElement
interface ImageElement extends Element default _Elements {
- ImageElement([String src, int height, int width]);
+ ImageElement([String src, int width, int height]);
/** @domName HTMLImageElement.align */
String align;
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698