Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 10540103: TabContentsWrapper -> TabContents, part 50. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 50. browser/ui/website_settings BUG=131026 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141725

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : removing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/ui/website_settings/website_settings.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-11 20:05:36 UTC) #1
markusheintz_
LGTM with comments. https://chromiumcodereview.appspot.com/10540103/diff/1004/chrome/browser/ui/website_settings/website_settings.cc File chrome/browser/ui/website_settings/website_settings.cc (right): https://chromiumcodereview.appspot.com/10540103/diff/1004/chrome/browser/ui/website_settings/website_settings.cc#newcode27 chrome/browser/ui/website_settings/website_settings.cc:27: #include "chrome/browser/ui/tab_contents/tab_contents.h" Please delete this line ...
8 years, 6 months ago (2012-06-12 09:40:55 UTC) #2
Avi (use Gerrit)
done.
8 years, 6 months ago (2012-06-12 18:51:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10540103/11001
8 years, 6 months ago (2012-06-12 18:52:35 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 20:23:09 UTC) #5
Change committed as 141725

Powered by Google App Engine
This is Rietveld 408576698