Issue 10540095: Reland r11753: Fix try..finally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10540095: Reland r11753: Fix try..finally. (Closed)

Created:
8 years, 6 months ago by Yang

Modified:
8 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland r11753: Fix try..finally. R=ulan@chromium.org BUG=129171 TEST=test-api/TryFinallyMessage, mjsunit/try-finally-continue.js Committed: https://code.google.com/p/v8/source/detail?r=11762

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -3 lines)			Patch
M	src/arm/full-codegen-arm.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download
M	src/assembler.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/assembler.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/full-codegen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	src/isolate.h	View		2 chunks	+15 lines, -1 line	0 comments	Download
M	src/isolate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A	test/mjsunit/try-finally-continue.js	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2012/06/11 12:45:58, Yang wrote: Offline comment to test case addressed. PTAL.

8 years, 6 months ago (2012-06-11 13:02:46 UTC) #2

LGTM