Removes reference counting from syncable::Directory::Kernel as it is no longer required because syn…

Removes reference counting of syncable::Directory::Kernel

No longer required, syncable::Directory is responsible now for deleting the dir kernel

BUG=119360
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143610

[rlarocque, 2012-06-12 19:26:50]

Hi Carlos, and welcome to Chromium!

+CC mal@chromium.org, so he can make sure we're doing this right.  I've never
walked someone through the contributor process before. 

The code looks fine, but I have a few other remarks:
- The name you added to the AUTHORS file doesn't quite match the one provided in
the contributor agreement (Sergio Carlos Morales Angeles).  Those two probably
should match.  

- The message you entered when creating the review, and which you can edit with
the 'Edit Issue' link, will live forever in version control as the commit
message.  These messages should start with a one line summary, preferably no
longer than 50 characters, followed by a blank line then a longer description of
the change (if necessary).

- If you want to address some comments to reviewers but don't want them in the
commit message, you can put it in the message you write when you publish the
review.

- You don't need to add everyone in the OWNERS file to the reviewers list. 
Normally one or two reviewers who are familiar with the files you are modifying
should be enough.  I find 'git blame' or 'svn blame' is a useful tool for
figuring out who is most familiar with which files.

[carloschilazo, 2012-06-19 15:33:51]

Hello, thank you very much for your feedback.

I have synced and re-applied my patch and entered my full name in the AUTHORS
file.

I will re-upload it shortly, and again thank you very much for your feedback
about code submission, I will do it like that from now on.

[rlarocque, 2012-06-21 01:01:20]

On 2012/06/19 15:33:51, carloschilazo wrote:
> Hello, thank you very much for your feedback.
> 
> I have synced and re-applied my patch and entered my full name in the AUTHORS
> file.
> 
> I will re-upload it shortly, and again thank you very much for your feedback
> about code submission, I will do it like that from now on.

Hi Carlos,

I'm sorry about this, but that file was recently refactored out of existence
yesterday.  The Directory is now in sync/syncable/directory.h.  That was my bad,
I forgot this change was outstanding.  

Could you re-apply this patch on top of the latest trunk, then re-upload?  Once
that's done I should be able to approve and commit it.  

Thanks!

[Mark Larson, 2012-06-21 03:11:51]

The AUTHORS change and the CLA look good to me. 

Note: I don't care whether the names match... the VCS tracks id by email
address, so as long as the id used to submit the code matches the id that signed
the CLA, we're good.

[carloschilazo, 2012-06-21 06:26:56]

Thank you both, I have re-uploaded the patch now for the refactored files
(directory{.h,.cc} instead of (syncable{.h,.cc})

Thanks!

[rlarocque, 2012-06-21 17:58:06]

On 2012/06/21 06:26:56, carloschilazo wrote:
> Thank you both, I have re-uploaded the patch now for the refactored files
> (directory{.h,.cc} instead of (syncable{.h,.cc})
> 
> Thanks!

LGTM.  I'll start the trybots.

[carloschilazo, 2012-06-22 15:19:13]

> LGTM.  I'll start the trybots.

Hi, is there any update about the try results?

[rlarocque, 2012-06-22 16:35:43]

On 2012/06/22 15:19:13, carloschilazo wrote:
> > LGTM.  I'll start the trybots.
> 
> Hi, is there any update about the try results?

They went fine.  

I didn't have time to watch the commit yesterday.  I'll try to commit it this
morning.

[rlarocque, 2012-06-22 18:06:16]

On 2012/06/22 16:35:43, rlarocque wrote:
> On 2012/06/22 15:19:13, carloschilazo wrote:
> > > LGTM.  I'll start the trybots.
> > 
> > Hi, is there any update about the try results?
> 
> They went fine.  
> 
> I didn't have time to watch the commit yesterday.  I'll try to commit it this
> morning.

Committed as r143610.

http://src.chromium.org/viewvc/chrome?view=rev&revision=143610