Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10540087: Add a mouse lock test to verify bubble clear when tab focus lost. (Closed)

Created:
8 years, 6 months ago by dyu1
Modified:
8 years, 6 months ago
Reviewers:
scheib, Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Add a mouse lock test to verify bubble clear when tab focus lost. -testNoMLBubbleWhenTabLoseFocus TEST=none BUG=131702 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141717

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/functional/fullscreen_mouselock.py View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dyu1
8 years, 6 months ago (2012-06-09 01:36:12 UTC) #1
Nirnimesh
https://chromiumcodereview.appspot.com/10540087/diff/1/chrome/test/functional/fullscreen_mouselock.py File chrome/test/functional/fullscreen_mouselock.py (right): https://chromiumcodereview.appspot.com/10540087/diff/1/chrome/test/functional/fullscreen_mouselock.py#newcode373 chrome/test/functional/fullscreen_mouselock.py:373: self.RunCommand(pyauto.IDC_NEW_TAB) Use AppendTab instead
8 years, 6 months ago (2012-06-09 08:09:06 UTC) #2
scheib
lgtm
8 years, 6 months ago (2012-06-11 16:15:40 UTC) #3
dyu1
http://codereview.chromium.org/10540087/diff/1/chrome/test/functional/fullscreen_mouselock.py File chrome/test/functional/fullscreen_mouselock.py (right): http://codereview.chromium.org/10540087/diff/1/chrome/test/functional/fullscreen_mouselock.py#newcode373 chrome/test/functional/fullscreen_mouselock.py:373: self.RunCommand(pyauto.IDC_NEW_TAB) On 2012/06/09 08:09:06, Nirnimesh wrote: > Use AppendTab ...
8 years, 6 months ago (2012-06-12 17:01:21 UTC) #4
Nirnimesh
LGTM
8 years, 6 months ago (2012-06-12 19:17:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyu@chromium.org/10540087/2002
8 years, 6 months ago (2012-06-12 19:54:40 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 19:54:54 UTC) #7 
Change committed as 141717

Powered by Google App Engine
This is Rietveld 408576698