Coverity: Remove dead code.

chrome/browser/history/scored_history_match.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/scored_history_match.h"
 
 #include <algorithm>
 #include <functional>
 #include <iterator>
 #include <numeric>
@@ skipping 426 matching lines @@
       // Linearly extrapolate between 1 and 7 days so 7 days has a score of 70.
       unnormalized_recency_score = 70 + (7 - days_ago) * (100 - 70) / (7 - 1);
     } else if (days_ago <= 30) {
       // Linearly extrapolate between 7 and 30 days so 30 days has a score
       // of 50.
       unnormalized_recency_score = 50 + (30 - days_ago) * (70 - 50) / (30 - 7);
     } else if (days_ago <= 90) {
       // Linearly extrapolate between 30 and 90 days so 90 days has a score
       // of 20.
       unnormalized_recency_score = 20 + (90 - days_ago) * (50 - 20) / (90 - 30);
-    } else if (days_ago <= 365) {
+    } else {
       // Linearly extrapolate between 90 and 365 days so 365 days has a score
       // of 10.
       unnormalized_recency_score =
           10 + (365 - days_ago) * (20 - 10) / (365 - 90);
-    } else {
-      // greater than a year.
-      unnormalized_recency_score = 10;

[kmadhusu, 2012/06/08 19:51:14]

Since days_ago is always between 0 and 365, execution cannot reach this
statement.

[James Hawkins, 2012/06/12 20:38:57]

Hmm I looked at this Coverity defect, and had reservations.  This change relies
on the fact that kDaysToPrecomputeRecencyScoresFor is 365, which this code
should not know about.  I don't know what the best solution is (maybe this is
the best solution).

     }
     days_ago_to_recency_score[days_ago] = unnormalized_recency_score / 100.0;
     if (days_ago > 0) {
       DCHECK_LE(days_ago_to_recency_score[days_ago],
                 days_ago_to_recency_score[days_ago - 1]);
     }
   }
 }
 
 // static
 float ScoredHistoryMatch::GetPopularityScore(int typed_count,
                                              int visit_count) {
   // The max()s are to guard against database corruption.
   return (std::max(typed_count, 0) * 5.0 + std::max(visit_count, 0) * 3.0) /
       (5.0 + 3.0);
 }
 
 }  // namespace history