Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2219)

Unified Diff: chrome/renderer/autofill/password_generation_manager.h

Issue 10540069: Refactor detection of account creation forms and fix two minor issues. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/autofill/password_generation_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/password_generation_manager.h
diff --git a/chrome/renderer/autofill/password_generation_manager.h b/chrome/renderer/autofill/password_generation_manager.h
index e22531ead8a75269036363c34e9b4a9629e2d2a6..72c236cdf0959e0e5f9e2f8cd506dc53195e5a3c 100644
--- a/chrome/renderer/autofill/password_generation_manager.h
+++ b/chrome/renderer/autofill/password_generation_manager.h
@@ -40,7 +40,7 @@ class PasswordGenerationManager : public content::RenderViewObserver,
private:
// RenderViewObserver:
- virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
+ virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;
// WebTextFieldDecoratorClient:
virtual bool shouldAddDecorationTo(
@@ -50,7 +50,10 @@ class PasswordGenerationManager : public content::RenderViewObserver,
virtual WebKit::WebCString imageNameForDisabledState() OVERRIDE;
virtual WebKit::WebCString imageNameForReadOnlyState() OVERRIDE;
virtual void handleClick(WebKit::WebInputElement& element) OVERRIDE;
- virtual void willDetach(const WebKit::WebInputElement&) OVERRIDE;
+ virtual void willDetach(const WebKit::WebInputElement& element) OVERRIDE;
+
+ bool IsAccountCreationForm(const WebKit::WebFormElement& form,
+ std::vector<WebKit::WebInputElement>* passwords);
// Message handlers.
void OnPasswordAccepted(const string16& password);
« no previous file with comments | « no previous file | chrome/renderer/autofill/password_generation_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698