Only generate assert in checked mode.

lib/compiler/implementation/ssa/builder.dart

Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart	(revision 8394)
+++ lib/compiler/implementation/ssa/builder.dart	(working copy)
@@ -2372,6 +2372,10 @@
   visitStaticSend(Send node) {
     Selector selector = elements.getSelector(node);
     Element element = elements[node];
+    if (element == compiler.assertMethod && !compiler.enableUserAssertions) {

[kasperl, 2012/06/08 05:34:05]

===?

[ngeoffray, 2012/06/08 09:40:58]

Done.

+      stack.add(graph.addConstantNull());

[karlklose, 2012/06/08 07:42:42]

I guess we add null here because we do not check that assert(...) is an
statement. However, as an expression, a call to something with the name assert
can never resolve to assertMethod. I think have to resolve assert(...)
differently when it is not in a statement expression context.

[ahe, 2012/06/08 07:59:14]

I don't think Nicolas needs to worry about this now, we are a few people that
plan to look at negative tests, and it would be fine if Nicolas defers this
issue to us.

[ngeoffray, 2012/06/08 09:40:58]

OK. Note that I think we will keep the the addConstantNull to not complicate the
builder already. The resolver has done all the work, we know the builder will
just remove this constantNull later on.

+      return;
+    }
     compiler.ensure(element.kind !== ElementKind.GENERATIVE_CONSTRUCTOR);
     HInstruction target = new HStatic(element);
     add(target);