Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10540049: Improve representation inference (Closed)

Created:
8 years, 6 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improve representation inference - Extend HValue interface to allow splitting observed input representation (comming from type feedback) from required input representation (dictated by instruction itself). Currently all instructions except for bitwise binary operations have this representations match. For bitwise binary operations hydrogen builder unconditionaly forces Integer32 representation for those operations that have Double type feedback. Thus causing representation inference to incorrectly count such uses as Integer32 instead of Double. This change also prepares for more fine grained type feedback for inputs of binary operations. - For phies that are not convertable to Integer32 discard direct and indirect use count of Integer32 type to avoid propagation of these uses to connected phies. R=jkummerow@chromium.org BUG=v8:2096 Committed: https://code.google.com/p/v8/source/detail?r=11737

Patch Set 1 #

Patch Set 2 : split ordering issue for non-convertable-to-integer computation #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -11 lines) Patch
M src/hydrogen.cc View 1 3 chunks +30 lines, -9 lines 2 comments Download
M src/hydrogen-instructions.h View 5 chunks +27 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 6 months ago (2012-06-07 14:02:16 UTC) #1
Jakob Kummerow
LGTM with nits. Medium-term, I want to move special handling of observed input representations from ...
8 years, 6 months ago (2012-06-07 15:38:05 UTC) #2
Vyacheslav Egorov (Google)
8 years, 6 months ago (2012-06-08 09:23:10 UTC) #3
Thanks for the review! Landed.

Of course storage for observed input representation should be moved to HBinaryOp
when there will be something to store in it. I did not want to waste space in
the IR.

Powered by Google App Engine
This is Rietveld 408576698