Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 10540042: Move remaining webkit storage unit tests to content_unittests (Closed)

Created:
8 years, 6 months ago by adamk
Modified:
8 years, 6 months ago
Reviewers:
michaeln, tony, jam
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, kinuko
Visibility:
Public.

Description

Move remaining webkit storage unit tests to content_unittests This includes appcache, blob, database, dom_storage, and quota. Many tests needed MessageLoops, which I've added as appropriate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -53 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 3 chunks +48 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_group_unittest.cc View 6 chunks +8 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_host_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_quota_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/appcache/appcache_service_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/appcache/mock_appcache_storage_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/blob/shareable_file_reference_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/database/database_connections_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/database/database_quota_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/database/database_tracker_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M webkit/dom_storage/dom_storage_area_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/dom_storage/dom_storage_context_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/mock_quota_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/quota_database_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/quota/quota_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/quota_temporary_storage_evictor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 2 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
adamk
This change was suggested by Tony, and is a followup to a recent move of ...
8 years, 6 months ago (2012-06-07 02:14:16 UTC) #1
michaeln
lgtm, thanx for searching and destroying
8 years, 6 months ago (2012-06-07 05:08:02 UTC) #2
jam
lgtm
8 years, 6 months ago (2012-06-07 15:12:24 UTC) #3
tony
lgtm, thanks for the cleanup!
8 years, 6 months ago (2012-06-07 16:52:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/10540042/1
8 years, 6 months ago (2012-06-07 17:47:05 UTC) #5
commit-bot: I haz the power
Try job failure for 10540042-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-07 19:28:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/10540042/1
8 years, 6 months ago (2012-06-07 20:57:08 UTC) #7
commit-bot: I haz the power
Try job failure for 10540042-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-07 22:37:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/10540042/1
8 years, 6 months ago (2012-06-07 23:39:28 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 00:57:23 UTC) #10
Change committed as 141139

Powered by Google App Engine
This is Rietveld 408576698