linux: Pass subpixel positioning setting to WebKit.

linux: Pass subpixel positioning setting to WebKit.

This makes us configure renderers appropriately based on
--enable-text-subpixel-positioning.  It also updates
SandboxIPCProcess to pass the flag through so the results
returned by its calls to WebFontInfo::renderStyleForStrike()
will reflect the setting.

BUG=125066
TEST=manual: both regular and web fonts within the renderer use subpixel positioning when --enable-text-subpixel-positioning is set


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141246

[Daniel Erat, 2012-06-06 23:31:51]

This depends on the change from https://bugs.webkit.org/show_bug.cgi?id=88263.

[tony, 2012-06-06 23:43:16]

https://chromiumcodereview.appspot.com/10540038/diff/1/content/browser/render...
File content/browser/renderer_host/render_sandbox_host_linux.cc (right):

https://chromiumcodereview.appspot.com/10540038/diff/1/content/browser/render...
content/browser/renderer_host/render_sandbox_host_linux.cc:71:
switches::kEnableTextSubpixelPositioning));
How does this command line switch get set on the sandbox IPC process?

[tony, 2012-06-07 00:04:42]

Which is to say, the changes to RendererPreferences LGTM, but I don't know the
sandboxipc code.  Maybe agl, markus or jln can review that part.

[Daniel Erat, 2012-06-07 00:13:34]

https://chromiumcodereview.appspot.com/10540038/diff/1/content/browser/render...
File content/browser/renderer_host/render_sandbox_host_linux.cc (right):

https://chromiumcodereview.appspot.com/10540038/diff/1/content/browser/render...
content/browser/renderer_host/render_sandbox_host_linux.cc:71:
switches::kEnableTextSubpixelPositioning));
On 2012/06/06 23:43:16, tony wrote:
> How does this command line switch get set on the sandbox IPC process?

That's a good question (for Adam). :-)  It seems to work.  Markus wasn't sure
where this code is running when I asked him.

[agl, 2012-06-07 21:55:22]

lgtm

https://chromiumcodereview.appspot.com/10540038/diff/1/content/browser/render...
File content/browser/renderer_host/render_sandbox_host_linux.cc (right):

https://chromiumcodereview.appspot.com/10540038/diff/1/content/browser/render...
content/browser/renderer_host/render_sandbox_host_linux.cc:71:
switches::kEnableTextSubpixelPositioning));
I have no idea either. How does this even compile? There's no 
setSubpixelPositioning function added in this CL. Is it a WebKit change?

(After syncing WebKit)

Ok, I see it. Yea, seems like it should work.

[commit-bot: I haz the power, 2012-06-08 13:06:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10540038/10

[commit-bot: I haz the power, 2012-06-08 13:06:37]

Presubmit check for 10540038-10 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser/renderer_host
    content/common
    content/public
    content/renderer

[Daniel Erat, 2012-06-08 13:12:49]

John, mind reviewing for content/?

[jam, 2012-06-08 16:13:49]

lgtm

[commit-bot: I haz the power, 2012-06-08 16:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10540038/10

[commit-bot: I haz the power, 2012-06-08 18:50:58]

Change committed as 141246