Use 2 buffers on presumable good Windows boxes.

media/audio/audio_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Software adjust volume of samples, allows each audio stream its own
 // volume without impacting master volume for chrome and other applications.
 
 // Implemented as templates to allow 8, 16 and 32 bit implementations.
 // 8 bit is unsigned and biased by 128.
 
 // TODO(vrk): This file has been running pretty wild and free, and it's likely
 // that a lot of the functions can be simplified and made more elegant. Revisit
 // after other audio cleanup is done. (crbug.com/120319)
 
 #include <algorithm>
 #include <limits>
 
 #include "base/atomicops.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/shared_memory.h"
 #include "base/time.h"
 #if defined(OS_WIN)
+#include "base/sys_info.h"
 #include "base/win/windows_version.h"
 #include "media/audio/audio_manager_base.h"
 #endif
 #include "media/audio/audio_parameters.h"
 #include "media/audio/audio_util.h"
 #if defined(OS_MACOSX)
 #include "media/audio/mac/audio_low_latency_input_mac.h"
 #include "media/audio/mac/audio_low_latency_output_mac.h"
 #endif
 #if defined(OS_WIN)
@@ skipping 478 matching lines @@
 }
 
 #if defined(OS_WIN)
 
 bool IsWASAPISupported() {
   // Note: that function correctly returns that Windows Server 2003 does not
   // support WASAPI.
   return base::win::GetVersion() >= base::win::VERSION_VISTA;
 }
 
+int NumberOfWaveOutBuffers() {
+  // Simple heuristic: use 3 buffers on single-core system or on Vista,
+  // 3 otherwise.

[scherkus (not reviewing), 2012/06/07 17:25:41]

"use 3 buffers [...], 3 otherwise" ?

do you mean 2?

I'd also like to see a small explanation / URL link that explains why vista gets
stuck w/ 3 buffers and not XP nor Win7

[enal1, 2012/06/07 20:56:22]

Done.

+  int num_buffers = 2;
+  if ((base::SysInfo::NumberOfProcessors() < 2) ||
+      (base::win::GetVersion() == base::win::VERSION_VISTA)) {
+    num_buffers = 3;
+  }
+  return num_buffers;

[scherkus (not reviewing), 2012/06/07 17:25:41]

nit: how about dropping the num_buffers stuff and writing this as:

if (cpus < 2 || win == VISTA) {
  return 3;
}
return 2;

[enal1, 2012/06/07 20:56:22]

Done.

+}
+
 #endif
 
 }  // namespace media