Issue 10540020: IWYU nit in ppapi_proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10540020: IWYU nit in ppapi_proxy (Closed)

Created:
8 years, 6 months ago by Roland McGrath

Modified:
8 years, 6 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

IWYU nit in ppapi_proxy Technically one is always supposed to do #include <sys/types.h> before doing #include <sys/mman.h>. For the newlib <sys/mman.h> this actually matters, as otherwise off_t will be undefined when it's used in the mmap prototype. Newer libstdc++ no longer implicitly includes <sys/types.h> in places that it used to, so this nit is newly noticed. BUG= none TEST= none R=sehr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140777

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages