Issue 3264. Use field type is formal initializer has to declared type

compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
index e136d9000d76286bc772f4add4e388b27bec0319..d52ea7f7fedb8be7c905f1e5a04423a6c02ce443 100644
--- a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
+++ b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
@@ -14,6 +14,7 @@ import com.google.dart.compiler.ast.DartClass;
 import com.google.dart.compiler.ast.DartExpression;
 import com.google.dart.compiler.ast.DartField;
 import com.google.dart.compiler.ast.DartFieldDefinition;
+import com.google.dart.compiler.ast.DartFunction;
 import com.google.dart.compiler.ast.DartFunctionTypeAlias;
 import com.google.dart.compiler.ast.DartIdentifier;
 import com.google.dart.compiler.ast.DartMethodDefinition;
@@ -22,6 +23,7 @@ import com.google.dart.compiler.ast.DartNode;
 import com.google.dart.compiler.ast.DartParameter;
 import com.google.dart.compiler.ast.DartParameterizedTypeNode;
 import com.google.dart.compiler.ast.DartPropertyAccess;
+import com.google.dart.compiler.ast.DartThisExpression;
 import com.google.dart.compiler.ast.DartUnit;
 import com.google.dart.compiler.ast.Modifiers;
 import com.google.dart.compiler.common.HasSourceInfo;
@@ -99,12 +101,61 @@ public class MemberBuilder {
       beginClassContext(node);
       EnclosingElement previousEnclosingElement = enclosingElement;
       enclosingElement = node.getElement();
-      this.visit(node.getMembers());
+      // visit fields, to make their Elements ready for constructor parameters
+      for (DartNode member : node.getMembers()) {
+        if (member instanceof DartFieldDefinition) {
+          member.accept(this);
+        }
+      }
+      // visit all other members
+      for (DartNode member : node.getMembers()) {
+        if (!(member instanceof DartFieldDefinition)) {
+          member.accept(this);
+        }
+      }
+      // done with this class
       enclosingElement = previousEnclosingElement;
       endClassContext();
       return null;
     }
 
+    private void checkParameterInitializer(DartMethodDefinition method, DartParameter parameter) {
+      if (Elements.isNonFactoryConstructor(method.getElement())) {
+        if (method.getModifiers().isRedirectedConstructor()) {
+          resolutionError(parameter.getName(),
+              ResolverErrorCode.PARAMETER_INIT_WITH_REDIR_CONSTRUCTOR);
+        }
+
+        FieldElement element =
+          Elements.lookupLocalField((ClassElement) currentHolder, parameter.getParameterName());
+        if (element == null) {
+          resolutionError(parameter, ResolverErrorCode.PARAMETER_NOT_MATCH_FIELD,
+                          parameter.getName());
+        } else if (element.isStatic()) {
+          resolutionError(parameter,
+                          ResolverErrorCode.PARAMETER_INIT_STATIC_FIELD,
+                          parameter.getName());
+        }
+
+        // Field parameters are not visible as parameters, so we do not declare them
+        // in the context. Instead we record the resolved field element.
+        Elements.setParameterInitializerElement(parameter.getElement(), element);
+
+        // The editor expects the referenced elements to be non-null
+        DartPropertyAccess prop = (DartPropertyAccess)parameter.getName();
+        prop.setElement(element);
+        prop.getName().setElement(element);
+
+        // If no type specified, use type of field.
+        if (parameter.getTypeNode() == null && element != null) {
+          Elements.setType(parameter.getElement(), element.getType());
+        }
+      } else {
+        resolutionError(parameter.getName(),
+            ResolverErrorCode.PARAMETER_INIT_OUTSIDE_CONSTRUCTOR);
+      }
+    }
+
     @Override
     public Element visitFunctionTypeAlias(DartFunctionTypeAlias node) {
       isStatic = false;
@@ -167,6 +218,20 @@ public class MemberBuilder {
       }
       return null;
     }
+    
+    @Override
+    protected void resolveFunctionWithParameters(DartFunction node, MethodElement element) {
+      super.resolveFunctionWithParameters(node, element);
+      // Bind "formal initializers" to fields.
+      if (node.getParent() instanceof DartMethodDefinition) {
+        DartMethodDefinition method = (DartMethodDefinition) node.getParent();
+        for (DartParameter parameter : node.getParameters()) {
+          if (parameter.getQualifier() instanceof DartThisExpression) {
+            checkParameterInitializer(method, parameter);
+          }
+        }
+      }
+    }
 
     @Override
     public Element visitFieldDefinition(DartFieldDefinition node) {
@@ -253,6 +318,7 @@ public class MemberBuilder {
         case CONSTRUCTOR:
           return (ConstructorNodeElement) e;
       }
+
       // If the constructor name resolves to a class or there was an error,
       // create the unnamed constructor.
       return Elements.constructorFromMethodNode(method, "", (ClassElement) currentHolder,