Issue 10540007: Map operator [] directly to native implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10540007: Map operator [] directly to native implementation. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Map operator [] directly to native implementation. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=8319

Patch Set 1 #

Total comments: 3

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -30 lines)			Patch
	M	lib/dom/scripts/systemnative.py	View		2 chunks	+3 lines, -5 lines	3 comments	Download
	M	lib/html/dartium/html_dartium.dart	View		8 chunks	+9 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/10540007/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10540007/diff/1/lib/dom/scripts/systemnative.py#newcode756 lib/dom/scripts/systemnative.py:756: html_name = '_item' do we need it still?

8 years, 6 months ago (2012-06-05 16:38:51 UTC) #2

podivilov

8 years, 6 months ago (2012-06-05 16:45:24 UTC) #3

Anton Muhin

8 years, 6 months ago (2012-06-05 16:49:19 UTC) #4

lgtm

https://chromiumcodereview.appspot.com/10540007/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10540007/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:756: html_name = '_item'
Ok, thanks.
On 2012/06/05 16:45:25, podivilov wrote:
> On 2012/06/05 16:38:51, antonmuhin wrote:
> > do we need it still?
> 
> Yes, we still need to generate native implementation.

Expand Messages | Collapse Messages