chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc - Issue 10539169: Prototype version of the first-run dialog for Windows 8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 10539169: Prototype version of the first-run dialog for Windows 8 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed up a comment. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/external_protocol/external_protocol_handler_unittest.cc » ('j') | chrome/browser/resources/set_as_metro_default.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

index e154744de7d69c91e9ea565b171547f2c85329f0..0a9666fb53a00d9010ab9acd986873d79be87d79 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

@@ -118,7 +118,7 @@ class FakeProtocolClientWorker

private:

virtual ~FakeProtocolClientWorker() {}

- virtual ShellIntegration::DefaultWebClientState CheckIsDefault() {

+ virtual ShellIntegration::DefaultWebClientState CheckIsDefault() OVERRIDE {

if (force_failure_) {

return ShellIntegration::NOT_DEFAULT_WEB_CLIENT;

} else {

@@ -126,7 +126,9 @@ class FakeProtocolClientWorker

}

- virtual void SetAsDefault(bool interactive_permitted) {}

+ virtual bool SetAsDefault(bool interactive_permitted) OVERRIDE {

+ return true;

+ }

private:

bool force_failure_;