Prototype version of the first-run dialog for Windows 8

chrome/installer/util/shell_util.cc

Index: chrome/installer/util/shell_util.cc
diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc
index 229abe52f79b9b56664f144c7750c697bdd8306b..3d7a990064ae51300e4c742a9eeac6e8ea8fc8da 100644
--- a/chrome/installer/util/shell_util.cc
+++ b/chrome/installer/util/shell_util.cc
@@ -613,7 +613,7 @@ bool LaunchSelectDefaultProtocolHandlerDialog(const wchar_t* protocol) {
   if (FAILED(hr))
     return false;
   SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
-  return true;
+  return SUCCEEDED(hr);

[grt (UTC plus 2), 2012/06/21 15:18:43]

SUCCEEDED(hr) -> true

[motek., 2012/06/21 18:28:10]

Done.

 }
 
 // Launches the Windows 7 and Windows 8 application association dialog, which
@@ -1241,6 +1241,7 @@ bool ShellUtil::ShowMakeChromeDefaultSystemUI(BrowserDistribution* dist,
   // "Set Program Associations" section of the "Default Programs"
   // control panel, which is a mess, or pop the concise "How you want to open
   // webpages?" dialog.  We choose the latter.
+  // Return true only when the user took an action and there was no error.
   return LaunchSelectDefaultProtocolHandlerDialog(L"http");
 }