Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: lib/unittest/core_matchers.dart

Issue 10539163: Revert 8668 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/unittest/unittest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/core_matchers.dart
===================================================================
--- lib/unittest/core_matchers.dart (revision 8672)
+++ lib/unittest/core_matchers.dart (working copy)
@@ -147,7 +147,8 @@
* * A [Function] that throws an exception when called. The function cannot
* take any arguments. If you want to test that a function expecting
* arguments throws, wrap it in another zero-argument function that calls
- * the one you want to test.
+ * the one you want to test. The function will be called once upon success,
+ * or twice upon failure (the second time to get the failure description).
*
* * A [Future] that completes with an exception. Note that this creates an
* asynchronous expectation. The call to `expect()` that includes this will
@@ -209,11 +210,11 @@
}
Description describeMismatch(item, Description mismatchDescription) {
- if (_matcher == null) {
+ try {
+ item();
return mismatchDescription.add(' no exception');
- } else {
- return mismatchDescription.
- add(' no exception or exception does not match ').
+ } catch (final e) {
+ return mismatchDescription.add(' exception does not match ').
addDescriptionOf(_matcher);
}
}
« no previous file with comments | « no previous file | lib/unittest/unittest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698