Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: lib/compiler/implementation/enqueue.dart

Issue 10539156: Track fields which are known to be always set to integer constants (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comment and addressed initializers Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class EnqueueTask extends CompilerTask { 5 class EnqueueTask extends CompilerTask {
6 final Enqueuer codegen; 6 final Enqueuer codegen;
7 final Enqueuer resolution; 7 final Enqueuer resolution;
8 8
9 String get name() => 'Enqueue'; 9 String get name() => 'Enqueue';
10 10
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 280
281 void registerDynamicInvocation(SourceString methodName, Selector selector) { 281 void registerDynamicInvocation(SourceString methodName, Selector selector) {
282 assert(selector !== null); 282 assert(selector !== null);
283 registerInvocation(methodName, selector); 283 registerInvocation(methodName, selector);
284 } 284 }
285 285
286 void registerDynamicInvocationOf(Element element) { 286 void registerDynamicInvocationOf(Element element) {
287 addToWorkList(element); 287 addToWorkList(element);
288 } 288 }
289 289
290 void registerFieldInitializer(SourceString name, Type type, bool isInteger) {
291 task.measure(() {
292 universe.updateFieldIntegerInitializers(type, name, isInteger);
293 });
294 }
295
290 void registerDynamicGetter(SourceString methodName, Selector selector) { 296 void registerDynamicGetter(SourceString methodName, Selector selector) {
291 registerInvokedGetter(methodName, selector); 297 registerInvokedGetter(methodName, selector);
292 } 298 }
293 299
294 void registerDynamicSetter(SourceString methodName, Selector selector) { 300 void registerDynamicSetter(SourceString methodName, Selector selector) {
295 registerInvokedSetter(methodName, selector); 301 registerInvokedSetter(methodName, selector);
296 } 302 }
297 303
298 void registerFieldGetter(SourceString getterName, Type type) { 304 void registerFieldGetter(SourceString getterName, Type type) {
299 task.measure(() { 305 task.measure(() {
300 registerNewSelector(getterName, 306 registerNewSelector(getterName,
301 new TypedSelector(type, Selector.GETTER), 307 new TypedSelector(type, Selector.GETTER),
302 universe.fieldGetters); 308 universe.fieldGetters);
303 }); 309 });
304 } 310 }
305 311
306 void registerFieldSetter(SourceString setterName, Type type) { 312 void registerFieldSetter(SourceString setterName, Type type, bool isInteger) {
307 task.measure(() { 313 task.measure(() {
308 registerNewSelector(setterName, 314 registerNewSelector(setterName,
309 new TypedSelector(type, Selector.SETTER), 315 new TypedSelector(type, Selector.SETTER),
310 universe.fieldSetters); 316 universe.fieldSetters);
317 universe.updateFieldIntegerSetters(type, setterName, isInteger);
311 }); 318 });
312 } 319 }
313 320
314 // TODO(ngeoffray): This should get a type. 321 // TODO(ngeoffray): This should get a type.
315 void registerIsCheck(Element element) { 322 void registerIsCheck(Element element) {
316 universe.isChecks.add(element); 323 universe.isChecks.add(element);
317 } 324 }
318 325
319 void forEach(f(WorkItem work)) { 326 void forEach(f(WorkItem work)) {
320 while (!queue.isEmpty()) { 327 while (!queue.isEmpty()) {
321 f(queue.removeLast()); 328 f(queue.removeLast());
322 } 329 }
323 } 330 }
324 } 331 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698