Return RemoteFileStreamWriter from remote mount point provider.

Return RemoteFileStreamWriter from remote mount point provider.

BUG=127754
TEST=none. the code is to be used for future cross-fs operations.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142128

[kinaba, 2012-06-14 10:33:32]

Could you take a look? (Just filling the TODO, and should have no effect in the
product code yet.)

[kinuko, 2012-06-14 10:54:31]

lgtm!
 On Jun 14, 2012 7:33 PM, <kinaba@chromium.org> wrote:

> Reviewers: kinuko,
>
> Message:
> Could you take a look? (Just filling the TODO, and should have no effect
> in the
> product code yet.)
>
> Description:
> Return RemoteFileStreamWriter from remote mount point provider.
>
> BUG=127754
> TEST=none. the code is to be used for future cross-fs operations.
>
>
> Please review this at
http://codereview.chromium.**org/10539154/<http://codereview.chromium.org/105...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M webkit/chromeos/fileapi/cros_**mount_point_provider.cc
>
>
> Index: webkit/chromeos/fileapi/cros_**mount_point_provider.cc
> diff --git a/webkit/chromeos/fileapi/**cros_mount_point_provider.cc
> b/webkit/chromeos/fileapi/**cros_mount_point_provider.cc
> index 9a6bcb751acd9a7eff159d0be0b353**111c79f71c..**
> c9eaa6c3484fb651b1af1c30be0d9c**09afc3e4bf 100644
> --- a/webkit/chromeos/fileapi/**cros_mount_point_provider.cc
> +++ b/webkit/chromeos/fileapi/**cros_mount_point_provider.cc
> @@ -16,6 +16,7 @@
>  #include "third_party/WebKit/Source/**WebKit/chromium/public/**
> platform/WebFileSystem.h"
>  #include "third_party/WebKit/Source/**WebKit/chromium/public/**
> platform/WebString.h"
>  #include "webkit/chromeos/fileapi/file_**access_permissions.h"
> +#include "webkit/chromeos/fileapi/**remote_file_stream_writer.h"
>  #include "webkit/chromeos/fileapi/**remote_file_system_operation.**h"
>  #include "webkit/fileapi/file_system_**file_stream_reader.h"
>  #include "webkit/fileapi/file_system_**operation.h"
> @@ -276,8 +277,9 @@ fileapi::FileStreamWriter* CrosMountPointProvider::**
> CreateFileStreamWriter(
>   if (!mount_point)
>     return NULL;
>   if (mount_point->location == REMOTE) {
> -    // TODO(kinaba): return a gdata writer for remote file system.
> -    return NULL;
> +    return new fileapi::**RemoteFileStreamWriter(mount_**
> point->remote_proxy,
> +                                               url,
> +                                               offset);
>   }
>   FilePath root_path = mount_point->local_root_path;
>   return new fileapi::**LocalFileStreamWriter(
>
>
>

[commit-bot: I haz the power, 2012-06-14 11:02:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/10539154/1

[commit-bot: I haz the power, 2012-06-14 12:23:48]

Change committed as 142128