Always initialize session cache locks lazily.

net/third_party/nss/ssl/sslsnce.c

 /* This file implements the SERVER Session ID cache. 
  * NOTE:  The contents of this file are NOT used by the client.
  *
  * ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 (the "License"); you may not use this file except in compliance with
  * the License. You may obtain a copy of the License at
  * http://www.mozilla.org/MPL/
@@ skipping 1359 matching lines @@
                                                          maxCacheEntries, 
                                                          -1, -1);
 }
 
 SECStatus
 SSL_ConfigServerSessionIDCache( int      maxCacheEntries, 
                                 PRUint32 ssl2_timeout,
                                 PRUint32 ssl3_timeout, 
                           const char *   directory)
 {
-    ssl_InitSessionCacheLocks(PR_FALSE);
     return SSL_ConfigServerSessionIDCacheInstance(&globalCache, 
                 maxCacheEntries, ssl2_timeout, ssl3_timeout, directory, PR_FALSE);
 }
 
 SECStatus
 SSL_ShutdownServerSessionIDCacheInstance(cacheDesc *cache)
 {
     CloseCache(cache);
     return SECSuccess;
 }
@@ skipping 93 matching lines @@
 SSL_ConfigServerSessionIDCacheWithOpt(
                                 PRUint32 ssl2_timeout,
                                 PRUint32 ssl3_timeout, 
                                 const char *   directory,
                                 int maxCacheEntries,
                                 int maxCertCacheEntries,
                                 int maxSrvNameCacheEntries,
                                 PRBool enableMPCache)
 {
     if (!enableMPCache) {
-        ssl_InitSessionCacheLocks(PR_FALSE);

[Ryan Sleevi, 2012/06/14 01:23:34]

I don't believe this is correct.

Because the server process needs to configure the cache, it should be
initializing the cache locks, not lazily in the socket import.

         return ssl_ConfigServerSessionIDCacheInstanceWithOpt(&globalCache, 
            ssl2_timeout, ssl3_timeout, directory, PR_FALSE,
            maxCacheEntries, maxCertCacheEntries, maxSrvNameCacheEntries);
     } else {
         return ssl_ConfigMPServerSIDCacheWithOpt(ssl2_timeout, ssl3_timeout,
                 directory, maxCacheEntries, maxCertCacheEntries,
                                                  maxSrvNameCacheEntries);
     }
 }
 
@@ skipping 24 matching lines @@
     ** then isMultiProcess will already be set.
     ** If not, we'll set it below.
     */
     if (isMultiProcess) {
         if (cache && cache->sharedCache) {
             cache->sharedCache->everInherited = PR_TRUE;
         }
         return SECSuccess;      /* already done. */
     }
 
-    ssl_InitSessionCacheLocks(PR_FALSE);
-
     ssl_sid_lookup  = ServerSessionIDLookup;
     ssl_sid_cache   = ServerSessionIDCache;
     ssl_sid_uncache = ServerSessionIDUncache;
 
     if (!envString) {
         envString  = getenv(envVarName);
         if (!envString) {
             SET_ERROR_CODE
             return SECFailure;
         }
@@ skipping 677 matching lines @@
 }
 
 SECStatus 
 SSL_SetMaxServerCacheLocks(PRUint32 maxLocks)
 {
     PR_ASSERT(!"SSL servers are not supported on this platform. (SSL_SetMaxServerCacheLocks)");
     return SECFailure;
 }
 
 #endif /* XP_UNIX || XP_WIN32 */