src/ic.cc - Issue 10539141: Fix Kraken regression due to optimistic monomorphic element transitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 10539141: Fix Kraken regression due to optimistic monomorphic element transitions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index d7f0f3251c86b20106ba3fba360b80df24563ad9..47a72b495636465761ce27fe4a0d97a107430f78 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1602,7 +1602,7 @@ Handle<Code> KeyedIC::ComputeStub(Handle<JSObject> receiver,

monomorphic = true;

} else {

GetReceiverMapsForStub(Handle<Code>(target()), &target_receiver_maps);

- if (ic_state == MONOMORPHIC && is_transition_stub) {

+ if (ic_state == MONOMORPHIC && (is_transition_stub || stub_kind == LOAD)) {

// The first time a receiver is seen that is a transitioned version of the

// previous monomorphic receiver type, assume the new ElementsKind is the

// monomorphic type. This benefits global arrays that only transition

« no previous file with comments | « no previous file | no next file » | no next file with comments »