Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: content/browser/webkit_browsertest.cc

Issue 10539134: TabContentsWrapper -> TabContents, part 57. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: last use Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 #include "chrome/test/base/in_process_browser_test.h" 6 #include "chrome/test/base/in_process_browser_test.h"
7 #include "chrome/test/base/ui_test_utils.h" 7 #include "chrome/test/base/ui_test_utils.h"
8 #include "content/browser/web_contents/web_contents_impl.h" 8 #include "content/browser/web_contents/web_contents_impl.h"
9 #include "content/test/net/url_request_abort_on_end_job.h" 9 #include "content/test/net/url_request_abort_on_end_job.h"
10 10
(...skipping 10 matching lines...) Expand all
21 // after aborts. This test creates that condition, and it is passed 21 // after aborts. This test creates that condition, and it is passed
22 // if chrome does not crash. 22 // if chrome does not crash.
23 23
24 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, AbortOnEnd) { 24 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, AbortOnEnd) {
25 ASSERT_TRUE(test_server()->Start()); 25 ASSERT_TRUE(test_server()->Start());
26 URLRequestAbortOnEndJob::AddUrlHandler(); 26 URLRequestAbortOnEndJob::AddUrlHandler();
27 GURL url = test_server()->GetURL(kAsyncScriptThatAbortsOnEndPage); 27 GURL url = test_server()->GetURL(kAsyncScriptThatAbortsOnEndPage);
28 28
29 ui_test_utils::NavigateToURL(browser(), url); 29 ui_test_utils::NavigateToURL(browser(), url);
30 30
31 WebContents* web_contents = browser()->GetSelectedWebContents(); 31 WebContents* web_contents = browser()->GetActiveWebContents();
32 // If you are seeing this test fail, please strongly investigate the 32 // If you are seeing this test fail, please strongly investigate the
33 // possibility that http://crbug.com/75604 and 33 // possibility that http://crbug.com/75604 and
34 // https://bugs.webkit.org/show_bug.cgi?id=71122 have reverted before 34 // https://bugs.webkit.org/show_bug.cgi?id=71122 have reverted before
35 // marking this as flakey. 35 // marking this as flakey.
36 EXPECT_FALSE(web_contents->IsCrashed()); 36 EXPECT_FALSE(web_contents->IsCrashed());
37 } 37 }
38 38
39 // This is a browser test because the DumpRenderTree framework holds 39 // This is a browser test because the DumpRenderTree framework holds
40 // onto a Document* reference that blocks this reproduction from 40 // onto a Document* reference that blocks this reproduction from
41 // destroying the Document, so it is not a use after free unless 41 // destroying the Document, so it is not a use after free unless
42 // you don't have DumpRenderTree loaded. 42 // you don't have DumpRenderTree loaded.
43 43
44 // TODO(gavinp): remove this browser_test if we can get good LayoutTest 44 // TODO(gavinp): remove this browser_test if we can get good LayoutTest
45 // coverage of the same issue. 45 // coverage of the same issue.
46 const char kXsltBadImportPage[] = 46 const char kXsltBadImportPage[] =
47 "files/webkit/xslt-bad-import.html"; 47 "files/webkit/xslt-bad-import.html";
48 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, XsltBadImport) { 48 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, XsltBadImport) {
49 ASSERT_TRUE(test_server()->Start()); 49 ASSERT_TRUE(test_server()->Start());
50 URLRequestAbortOnEndJob::AddUrlHandler(); 50 URLRequestAbortOnEndJob::AddUrlHandler();
51 GURL url = test_server()->GetURL(kXsltBadImportPage); 51 GURL url = test_server()->GetURL(kXsltBadImportPage);
52 52
53 ui_test_utils::NavigateToURL(browser(), url); 53 ui_test_utils::NavigateToURL(browser(), url);
54 54
55 WebContents* web_contents = browser()->GetSelectedWebContents(); 55 WebContents* web_contents = browser()->GetActiveWebContents();
56 EXPECT_FALSE(web_contents->IsCrashed()); 56 EXPECT_FALSE(web_contents->IsCrashed());
57 } 57 }
OLDNEW
« no previous file with comments | « content/browser/speech/speech_recognition_browsertest.cc ('k') | content/browser/worker_host/test/worker_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698