Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 10539112: Revert 141680 - Adds parsing for the app_id field from an "open-with-" link (Closed)

Created:
8 years, 6 months ago by Greg Spencer (Chromium)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert 141680 - Adds parsing for the app_id field from an "open-with-" link in Drive. Later CLs will use app_id field to look up an associated app. Also adjusted unit test so that it would assert less and expect more. I expect more from my unit tests. :-) BUG=chromium:126895 TEST=Ran updated unit test. Review URL: https://chromiumcodereview.appspot.com/10546034 TBR=gspencer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -254 lines) Patch
M chrome/browser/chromeos/gdata/gdata_parser.h View 2 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_parser.cc View 3 chunks +6 lines, -49 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_parser_unittest.cc View 8 chunks +111 lines, -179 lines 0 comments Download
M chrome/test/data/chromeos/gdata/basic_feed.json View 2 chunks +1 line, -9 lines 0 comments Download
MM chrome/test/data/chromeos/gdata/entry.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Greg Spencer (Chromium)
8 years, 6 months ago (2012-06-12 18:01:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698